From owner-svn-src-head@freebsd.org Thu Jan 11 05:53:09 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C2EFDE6F944 for ; Thu, 11 Jan 2018 05:53:09 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-wm0-x234.google.com (mail-wm0-x234.google.com [IPv6:2a00:1450:400c:c09::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 505FC80369 for ; Thu, 11 Jan 2018 05:53:09 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-wm0-x234.google.com with SMTP id t8so3043504wmc.3 for ; Wed, 10 Jan 2018 21:53:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=oHKmsq07jISm9Kl6v9i9y4x6agf4QbT4JwXZNhMEyYo=; b=aecqhenHEtht0PEeai1amGQcISrfPW5d8/mfcnhwUGWnaANSiMATQLdXMtd8ZvDxC8 z3dYhztigvtbYY/wDVH5QWbotOGFT7a5qsIo9xGLu6X4iTc3hh1irLXmL52AAwNO/vLO sEBfC9VrmFaYHlbEU/p9hyp3TQsPloI9PY81oZF447mPQXLVXidZVkZhlF08KOACEnX2 eZZzOxe2Fp9JpeE0Ktm3cKtMl5rN39EosfxY699cMqWMJKaFzQdAMmNESSpN/65S0jzi aarFbEvIdkFPWT6/oR2lbcjdlRfSeRSIy7H/X7gU1hgtuXR89w7ywovnAX01ySxqZMgj Xvvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=oHKmsq07jISm9Kl6v9i9y4x6agf4QbT4JwXZNhMEyYo=; b=s8oiEIB569ENrTf6VZn6I5VRgMmMSSixlcGqnrOB5A0f91NshvcaB63dchrMwk1jMp HiwWZQXelZzz4cbg8DfTQA9Dz33rhxvsnmm6ReoMClAHWRw3FIYsdyrSui3vRKPY2ONa RJZiEdIE1y5EfefbCfD+gipekzPoquJjcyHK1SLQJHZMVgwAGvgOMtK56LzSmPw06m0f zj9MIgYP5L7m13U0PS5FVja41/qBOpLhjedJnOzycA3OuuCJiKll/Pu2qipF1OZ9TzOY MuTFehb0S3d8lERu9jFwsffhEzVA8O73DdeZUkf+oFotSLdkqvByar0JLqxZggp2wYuj zHjQ== X-Gm-Message-State: AKGB3mJ/y9RewfaKklATzTffJRTHqELy4Kgop0knq2hfOCNOhiCCWQez W3iMT2EJkky2Xmc4+buMSyrf0pXyeSG/a6e8XkSLZQ== X-Google-Smtp-Source: ACJfBovG5B+pez4Jh+3h7hJ69Q46qvbviPHIISUO3O4Ps6P0eFDEtxJQvilmL8iGcJFfnn/ujl713Rimpt3rnfbeG0A= X-Received: by 10.80.179.76 with SMTP id r12mr28869852edd.118.1515649987761; Wed, 10 Jan 2018 21:53:07 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.80.195.88 with HTTP; Wed, 10 Jan 2018 21:53:07 -0800 (PST) X-Originating-IP: [2603:300b:6:5100:18a2:a4f7:170:8dd9] In-Reply-To: <201801110536.w0B5aDJZ032451@repo.freebsd.org> References: <201801110536.w0B5aDJZ032451@repo.freebsd.org> From: Warner Losh Date: Wed, 10 Jan 2018 22:53:07 -0700 X-Google-Sender-Auth: PE_eQuSb6f_uuo1IvKQaIIygYF0 Message-ID: Subject: Re: svn commit: r327806 - in head: etc/mtree usr.bin/awk usr.bin/awk/tests To: Kyle Evans Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Jan 2018 05:53:09 -0000 On Wed, Jan 10, 2018 at 10:36 PM, Kyle Evans wrote: > Author: kevans > Date: Thu Jan 11 05:36:13 2018 > New Revision: 327806 > URL: https://svnweb.freebsd.org/changeset/base/327806 > > Log: > awk(1): Add necessary bits for connecting tests, but leave disconnected > > The NetBSD test suite has 24 tests for awk, and we pass exactly 4 of > them. > Add the necessary pieces for interested parties to easily connect the > tests and run them, but leave them disconnected for the time being. > > Some of these tests outright segfault in our awk, others just exhibit the > wrong behavior. > How many tests does NetBSD's awk pass? At least one of their patches causes our .m compiler awk script to fail, if I've applied it correctly. Warner > Added: > head/usr.bin/awk/tests/ > head/usr.bin/awk/tests/Makefile (contents, props changed) > Modified: > head/etc/mtree/BSD.tests.dist > head/usr.bin/awk/Makefile > > Modified: head/etc/mtree/BSD.tests.dist > ============================================================ > ================== > --- head/etc/mtree/BSD.tests.dist Thu Jan 11 03:11:41 2018 > (r327805) > +++ head/etc/mtree/BSD.tests.dist Thu Jan 11 05:36:13 2018 > (r327806) > @@ -536,6 +536,8 @@ > usr.bin > apply > .. > + awk > + .. > basename > .. > bmake > > Modified: head/usr.bin/awk/Makefile > ============================================================ > ================== > --- head/usr.bin/awk/Makefile Thu Jan 11 03:11:41 2018 (r327805) > +++ head/usr.bin/awk/Makefile Thu Jan 11 05:36:13 2018 (r327806) > @@ -1,5 +1,7 @@ > # $FreeBSD$ > > +.include > + > AWKSRC= ${SRCTOP}/contrib/one-true-awk > .PATH: ${AWKSRC} > > @@ -27,5 +29,9 @@ proctab.c: maketab > > build-tools: maketab > maketab: ytab.h maketab.c ${BUILD_TOOLS_META} > + > +# awk needs some work before we can connect these tests to the build > +#HAS_TESTS= > +SUBDIR.${MK_TESTS}+= tests > > .include > > Added: head/usr.bin/awk/tests/Makefile > ============================================================ > ================== > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/usr.bin/awk/tests/Makefile Thu Jan 11 05:36:13 2018 > (r327806) > @@ -0,0 +1,33 @@ > +# $FreeBSD$ > + > +PACKAGE= tests > + > +NETBSD_ATF_TESTS_SH= awk_test > + > +${PACKAGE}FILES+= d_assign_NF.awk > +${PACKAGE}FILES+= d_assign_NF.in > +${PACKAGE}FILES+= d_assign_NF.out > +${PACKAGE}FILES+= d_big_regexp.awk > +${PACKAGE}FILES+= d_big_regexp.in > +${PACKAGE}FILES+= d_big_regexp.out > +${PACKAGE}FILES+= d_end1.awk > +${PACKAGE}FILES+= d_end1.in > +${PACKAGE}FILES+= d_end1.out > +${PACKAGE}FILES+= d_end2.awk > +${PACKAGE}FILES+= d_end2.in > +${PACKAGE}FILES+= d_end2.out > +${PACKAGE}FILES+= d_period.awk > +${PACKAGE}FILES+= d_period.in > +${PACKAGE}FILES+= d_period.out > +${PACKAGE}FILES+= d_string1.awk > +${PACKAGE}FILES+= d_string1.out > +${PACKAGE}FILES+= d_tolower.awk > +${PACKAGE}FILES+= d_tolower.in > +${PACKAGE}FILES+= d_tolower.out > +${PACKAGE}FILES+= d_toupper.awk > +${PACKAGE}FILES+= d_toupper.in > +${PACKAGE}FILES+= d_toupper.out > + > +.include > + > +.include > >