From owner-cvs-src-old@FreeBSD.ORG Mon Mar 7 00:42:36 2011 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EEF9910656D8 for ; Mon, 7 Mar 2011 00:42:36 +0000 (UTC) (envelope-from yongari@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id DBBFC8FC13 for ; Mon, 7 Mar 2011 00:42:36 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.4/8.14.4) with ESMTP id p270gaUh054742 for ; Mon, 7 Mar 2011 00:42:36 GMT (envelope-from yongari@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.4/8.14.4/Submit) id p270gaqs054741 for cvs-src-old@freebsd.org; Mon, 7 Mar 2011 00:42:36 GMT (envelope-from yongari@repoman.freebsd.org) Message-Id: <201103070042.p270gaqs054741@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to yongari@repoman.freebsd.org using -f From: Pyun YongHyeon Date: Mon, 7 Mar 2011 00:42:22 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: RELENG_8 Subject: cvs commit: src/sys/dev/sis if_sis.c if_sisreg.h X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Mar 2011 00:42:37 -0000 yongari 2011-03-07 00:42:22 UTC FreeBSD src repository Modified files: (Branch: RELENG_8) sys/dev/sis if_sis.c if_sisreg.h Log: SVN rev 219356 on 2011-03-07 00:42:22Z by yongari MFC r219102: Make sure changing ownership of RX descriptor to be done as last operation. Previously ownership was transferred to hardware before setting address of new RX buffer such that it was possible for hardware to use wrong RX buffer address. While here keep compiler from re-ordering instructions by declaring descriptor members volatile. Memory barriers would do the same job but volatile is supposed to be cheaper than using memory barriers, especially on MP systems. Submitted by: marius Revision Changes Path 1.9.2.16 +1 -1 src/sys/dev/sis/if_sis.c 1.2.4.10 +2 -2 src/sys/dev/sis/if_sisreg.h