From owner-cvs-all@FreeBSD.ORG  Sat Aug 27 21:07:58 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@freebsd.org
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3E1FD16A421
	for <cvs-all@freebsd.org>; Sat, 27 Aug 2005 21:07:58 +0000 (GMT)
	(envelope-from keramida@ceid.upatras.gr)
Received: from nic.ach.sch.gr (nic.sch.gr [194.63.238.4])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 338A443D46
	for <cvs-all@freebsd.org>; Sat, 27 Aug 2005 21:07:55 +0000 (GMT)
	(envelope-from keramida@ceid.upatras.gr)
Received: (qmail 22054 invoked by uid 207); 27 Aug 2005 21:07:54 -0000
Received: from keramida@ceid.upatras.gr by nic by uid 201 with
	qmail-scanner-1.21 
	(sophie: 3.04/2.19/3.81.  Clear:RC:1(81.186.70.65):. 
	Processed in 0.581948 secs); 27 Aug 2005 21:07:54 -0000
Received: from dialup65.ach.sch.gr (HELO gothmog.gr) ([81.186.70.65])
	(envelope-sender <keramida@ceid.upatras.gr>)
	by nic.sch.gr (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP
	for <thompsa@freebsd.org>; 27 Aug 2005 21:07:53 -0000
Received: from gothmog.gr (gothmog [127.0.0.1])
	by gothmog.gr (8.13.4/8.13.4) with ESMTP id j7RL7lQ0001335;
	Sun, 28 Aug 2005 00:07:47 +0300 (EEST)
	(envelope-from keramida@ceid.upatras.gr)
Received: (from giorgos@localhost)
	by gothmog.gr (8.13.4/8.13.4/Submit) id j7RL7jjB001334;
	Sun, 28 Aug 2005 00:07:45 +0300 (EEST)
	(envelope-from keramida@ceid.upatras.gr)
Date: Sun, 28 Aug 2005 00:07:45 +0300
From: Giorgos Keramidas <keramida@ceid.upatras.gr>
To: Andrew Thompson <thompsa@freebsd.org>
Message-ID: <20050827210745.GC1208@gothmog.gr>
References: <200508112057.j7BKvxVs083144@repoman.freebsd.org>
	<200508120032.44995.max@love2party.net>
	<20050811225402.GA70630@heff.fud.org.nz>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20050811225402.GA70630@heff.fud.org.nz>
Cc: Max Laier <max@love2party.net>, src-committers@freebsd.org,
	cvs-all@freebsd.org, cvs-src@freebsd.org
Subject: Re: cvs commit: src/sys/net if_bridge.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 27 Aug 2005 21:07:58 -0000

On 2005-08-12 10:54, Andrew Thompson <thompsa@freebsd.org> wrote:
>>>> Use m_copypacket() which is an optimization of the common case
>>>> m_copym(m, 0, M_COPYALL, how).
>>>>
>>>> This is required for strict alignment architectures where we align the
>>>> IP header in the input path but m_copym() will create an unaligned copy
>>>> in bridge_broadcast(). m_copypacket() preserves alignment of the first
>>>> mbuf.
>>
>> I guess we should document this difference between m_copym and m_copypacket ?!
>
> It is in the comment block which is how I discovered it, but mbuf(9) is missing
> the info about alignment.
>
> uipc_mbuf.c:
>  /*
>   * Copy an entire packet, including header (which must be present). [...]

We should probably document it in the manpage too though.  How about
adding the same sentence to the ``Note:'' of m_copypacket() in mbuf.9?