From owner-svn-src-all@freebsd.org Tue Feb 27 16:51:53 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E5360F3689E for ; Tue, 27 Feb 2018 16:51:52 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x236.google.com (mail-it0-x236.google.com [IPv6:2607:f8b0:4001:c0b::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 711C082A51 for ; Tue, 27 Feb 2018 16:51:52 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x236.google.com with SMTP id a75so15856360itd.0 for ; Tue, 27 Feb 2018 08:51:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=yD3/qv0LiTRJa+uE9CLHfFIXHW33hDBLK6Blhd55Y6o=; b=TvMfsWvqU2TRiGML+QDc4ewUokw7zBdW/UImwApC/QqklBu9rT/0sol+0lZJzktUn0 zU9lCG47hnJ/YHjyv72PCpppRU0efpMX+8I/USm4vbzUGZJhn8li6DHCZhL+I+PgSvo8 Y56fdMBxYDOMsQcxHeQ9LP58/rr7zGAclu4Ij8rpq0uWZXyTido72nLBX51YsJY1R2Zz 0KkiZ63XeqvG86xp/mpA1i+ZNSO4ocPF2MxvDPhDArZWTStf8mXw4LXre1qei4pSfMM6 6ntdrfNNj4UJpS3sauEW4u7TunIjyxt33So31CxQBB3UtBonwSnHJDBCYPyFn2SYdtT5 Dj+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=yD3/qv0LiTRJa+uE9CLHfFIXHW33hDBLK6Blhd55Y6o=; b=d55aq4Ves/SDsC4q6g65DrWG46R19jJifpf6xqW+lQTesJGrR8p+5ROchdki23HElU YjOsOMXhIyBw1jBa8LAtzsjcTKDepaaeUUZenvrsqwKrXP07egJpOKZbIsNRv1psvm0D L5EMzvmCLRq1MqNMXdqX/JEgvLH55RpFmjPW1uoTYNcKa+wmozEVUOUnbBspRydn9wZF hS2A0ET+hG25keRw+GxmdNXA72tn/nxVID6SG47BmO6oMkToKjq+vpb2ucZhb+FVtLKp QiMfhuFB4ubproEbCZn2o1ZpsE0NfOoZ2d3btOtoqNjj0+ipX74yUcWpA1uM/fQnk8tC Krow== X-Gm-Message-State: APf1xPBg0twEloXFkh9Qt/ACRq5iZude6FjSS55g3sqZPC9pZeUx0v/r Y89apDTNFwDdBN1z7J5XxzDMclk6t4XneGEqB1srvQ== X-Google-Smtp-Source: AG47ELsiRx8TdCs4zBNFmNiccJTOiKMKllr1p0zLBaKgnbjQDzLvcxP0Jg2qIPXTUpa366TVePn33BcGyNHX9Akvf2Q= X-Received: by 10.36.4.65 with SMTP id 62mr2532932itb.57.1519750311544; Tue, 27 Feb 2018 08:51:51 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.201.67 with HTTP; Tue, 27 Feb 2018 08:51:50 -0800 (PST) X-Originating-IP: [50.227.106.226] In-Reply-To: References: <201802260316.w1Q3G4vc022314@repo.freebsd.org> From: Warner Losh Date: Tue, 27 Feb 2018 09:51:50 -0700 X-Google-Sender-Auth: kLKvn7dFlDb9Nqsks7vpa-4LvaY Message-ID: Subject: Re: svn commit: r330004 - in head/stand: . arm efi forth i386 mips powerpc sparc64 To: Kyle Evans Cc: Warner Losh , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Feb 2018 16:51:53 -0000 On Tue, Feb 27, 2018 at 9:47 AM, Kyle Evans wrote: > On Tue, Feb 27, 2018 at 10:36 AM, Warner Losh wrote: > > > > > > On Tue, Feb 27, 2018 at 8:33 AM, Kyle Evans wrote: > >> > >> n Tue, Feb 27, 2018 at 9:28 AM, Kyle Evans wrote: > >> > On Sun, Feb 25, 2018 at 9:16 PM, Warner Losh wrote: > >> >> Author: imp > >> >> Date: Mon Feb 26 03:16:04 2018 > >> >> New Revision: 330004 > >> >> URL: https://svnweb.freebsd.org/changeset/base/330004 > >> >> > >> >> Log: > >> >> Add NO_OBJ to those directories that don't make anything. > >> >> > >> >> For directories that don't many anything, add NO_OBJ=t just before > we > >> >> include bsd.init.mk. This prevents them from creating an OBJ > >> >> directory. In addition, prevent defs.mk from creating the machine > >> >> related links in these cases. They aren't needed and break, at > least > >> >> on stable, the read-only src tree build. > >> >> > >> > > >> > Any objection to also removing efi from i386 SUBDIR? It seems silly > >> > to be explicitly adding it when we know nothing here is applicable and > >> > it's going to take some amount of work to get there. > >> > >> In fact, this block [1] feels wrong, too... why are we adding efi to > >> SUBDIR for arch's that don't support it? I understand the GCC checks, > >> but libefi, loader, and boot1 are the main bits of efi/, why are these > >> stuck behind MACHINE_CPUARCH checks? > >> > >> [1] > >> https://svnweb.freebsd.org/base/head/stand/efi/Makefile?view=markup#l17 > > > > > > I think that none of the arch tests in that file are anywhere near legit > in > > that file. More cargo-cult kludgery to eliminate in the build system. > I'll > > take care of that. If i386 builds, we should keep it, otherwise we > > shouldn't. In fact, we should move all the EFI ifdef junk-o-matic crap > from > > Makefile. at the top level as well. > > > > Right- the arch tests surrounding the FDT bits are pointless and only > really stop us from building something we won't be using (since FDT is > default yes regardless of arch, for some reason). > > It would be nice if we could build efi/fdt based on whether we'll be > building an EFI loader w/ HAVE_FDT set rather than these arch tests, > but I understand that that's not necessarily straightforward. It all comes from a fundamental misunderstanding that there's three options for every build option: default yes, default no, and broken.... Warner > Lemme toss together a patch. > > > > Excellent. =) > > > Warner >