From owner-svn-src-all@FreeBSD.ORG Tue Apr 7 17:13:18 2009 Return-Path: Delivered-To: svn-src-all@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4E3EA1065673; Tue, 7 Apr 2009 17:13:18 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from tarsier.delphij.net (delphij-pt.tunnel.tserv2.fmt.ipv6.he.net [IPv6:2001:470:1f03:2c9::2]) by mx1.freebsd.org (Postfix) with ESMTP id E3BD68FC1C; Tue, 7 Apr 2009 17:13:17 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from tarsier.geekcn.org (tarsier.geekcn.org [211.166.10.233]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by tarsier.delphij.net (Postfix) with ESMTPS id 19BFE28448; Wed, 8 Apr 2009 01:13:17 +0800 (CST) Received: from localhost (tarsier.geekcn.org [211.166.10.233]) by tarsier.geekcn.org (Postfix) with ESMTP id D535DEDD1FE; Wed, 8 Apr 2009 01:13:16 +0800 (CST) X-Virus-Scanned: amavisd-new at geekcn.org Received: from tarsier.geekcn.org ([211.166.10.233]) by localhost (mail.geekcn.org [211.166.10.233]) (amavisd-new, port 10024) with ESMTP id 51irCMx-DFSM; Wed, 8 Apr 2009 01:13:12 +0800 (CST) Received: from charlie.delphij.net (adsl-76-237-33-62.dsl.pltn13.sbcglobal.net [76.237.33.62]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tarsier.geekcn.org (Postfix) with ESMTPSA id 7DEDAEDD1FD; Wed, 8 Apr 2009 01:13:09 +0800 (CST) DomainKey-Signature: a=rsa-sha1; s=default; d=delphij.net; c=nofws; q=dns; h=message-id:date:from:reply-to:organization:user-agent: mime-version:to:cc:subject:references:in-reply-to: x-enigmail-version:openpgp:content-type:content-transfer-encoding; b=tCAqfxK4yDQlddrl3iYgdfky2Gyv9ptV3DyUDLRPuZD1mB6y5069/4C+/WUDVk1Pp sce2+CZtBjJvIQBvgTSVw== Message-ID: <49DB89A4.4080507@delphij.net> Date: Tue, 07 Apr 2009 10:13:08 -0700 From: Xin LI Organization: The FreeBSD Project User-Agent: Thunderbird 2.0.0.21 (X11/20090324) MIME-Version: 1.0 To: John Baldwin References: <200904071640.n37GeWGb014706@svn.freebsd.org> <200904071307.29778.jhb@freebsd.org> In-Reply-To: <200904071307.29778.jhb@freebsd.org> X-Enigmail-Version: 0.95.7 OpenPGP: id=18EDEBA0; url=http://www.delphij.net/delphij.asc Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.ORG, svn-src-all@FreeBSD.ORG, src-committers@FreeBSD.ORG, Xin LI Subject: Re: svn commit: r190810 - head/sys/dev/hptmv X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: d@delphij.net List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Apr 2009 17:13:19 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 John Baldwin wrote: > On Tuesday 07 April 2009 12:40:32 pm Xin LI wrote: >> Author: delphij >> Date: Tue Apr 7 16:40:31 2009 >> New Revision: 190810 >> URL: http://svn.freebsd.org/changeset/base/190810 >> >> Log: >> When multiple cards are present, register a shutdown handler for each card >> instead of just register one for the first adapter. Without doing this >> there would be some data loss upon shutdown because data could be ignored >> when flushing to disk. > > Have you considered just using a device_shutdown routine? It is invoked at > shutdown_final as well but is easier to use (no need to keep track of > eventhandler tags, etc.). Yes for sure. What I really wanted to do is to keep the change as few as possible at this point, as the requester for update has tested his patch (slightly different) and we are approaching 7.2-RELEASE... Cheers, - -- Xin LI http://www.delphij.net/ FreeBSD - The Power to Serve! -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.11 (FreeBSD) iEYEARECAAYFAknbiaMACgkQi+vbBBjt66C+bACgvECvXYtfJRrgsl+5wDSXe3ty EOEAn3iL1o7OegT4A2P/T3o9fJ/5UvLT =bvSu -----END PGP SIGNATURE-----