From owner-svn-src-all@FreeBSD.ORG Sun Feb 7 07:50:42 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 06697106568B; Sun, 7 Feb 2010 07:50:42 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id EB1EC8FC1A; Sun, 7 Feb 2010 07:50:41 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o177ofOq082391; Sun, 7 Feb 2010 07:50:41 GMT (envelope-from imp@svn.freebsd.org) Received: (from imp@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id o177of7H082389; Sun, 7 Feb 2010 07:50:41 GMT (envelope-from imp@svn.freebsd.org) Message-Id: <201002070750.o177of7H082389@svn.freebsd.org> From: Warner Losh Date: Sun, 7 Feb 2010 07:50:41 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r203604 - head/usr.sbin/rpcbind X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Feb 2010 07:50:42 -0000 Author: imp Date: Sun Feb 7 07:50:41 2010 New Revision: 203604 URL: http://svn.freebsd.org/changeset/base/203604 Log: Initialize fromlen before calling recvfrom to avoid passing in random stack garbage. Obtained from: NetBSD 1.13 Modified: head/usr.sbin/rpcbind/rpcb_svc_com.c Modified: head/usr.sbin/rpcbind/rpcb_svc_com.c ============================================================================== --- head/usr.sbin/rpcbind/rpcb_svc_com.c Sun Feb 7 06:22:28 2010 (r203603) +++ head/usr.sbin/rpcbind/rpcb_svc_com.c Sun Feb 7 07:50:41 2010 (r203604) @@ -1224,6 +1224,7 @@ handle_reply(int fd, SVCXPRT *xprt) goto done; do { + fromlen = sizeof(ss); inlen = recvfrom(fd, buffer, RPC_BUF_MAX, 0, (struct sockaddr *)&ss, &fromlen); } while (inlen < 0 && errno == EINTR);