From owner-svn-src-all@freebsd.org  Tue Jun  5 03:12:10 2018
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 54F92FE6DB9;
 Tue,  5 Jun 2018 03:12:10 +0000 (UTC)
 (envelope-from kevans@freebsd.org)
Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "smtp.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id F15C87A539;
 Tue,  5 Jun 2018 03:12:09 +0000 (UTC)
 (envelope-from kevans@freebsd.org)
Received: from mail-lf0-f51.google.com (mail-lf0-f51.google.com
 [209.85.215.51])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 (Authenticated sender: kevans)
 by smtp.freebsd.org (Postfix) with ESMTPSA id 8DC5219411;
 Tue,  5 Jun 2018 03:12:09 +0000 (UTC)
 (envelope-from kevans@freebsd.org)
Received: by mail-lf0-f51.google.com with SMTP id v135-v6so1117424lfa.9;
 Mon, 04 Jun 2018 20:12:09 -0700 (PDT)
X-Gm-Message-State: APt69E3jLuYf5kSCcWeQwar4m1ZeaBeH33keb5IH3JtBPRlh6oZFpoCo
 z013ZAk+dldLj6WI/p3tyT7KOQTGSF2tUkQPnaQ=
X-Google-Smtp-Source: ADUXVKI5chUkeK/abH1FHEd9IvuIbHU637dsPNx02tklB8SFq/3zw1i6S5o6pJ6j5+9SnjIYXxLSWz52nO+7aBshTYw=
X-Received: by 2002:a2e:1188:: with SMTP id 8-v6mr14127721ljr.38.1528168327922; 
 Mon, 04 Jun 2018 20:12:07 -0700 (PDT)
MIME-Version: 1.0
Received: by 2002:a2e:3112:0:0:0:0:0 with HTTP;
 Mon, 4 Jun 2018 20:11:47 -0700 (PDT)
In-Reply-To: <201805252146.w4PLk7vL009258@repo.freebsd.org>
References: <201805252146.w4PLk7vL009258@repo.freebsd.org>
From: Kyle Evans <kevans@freebsd.org>
Date: Mon, 4 Jun 2018 22:11:47 -0500
X-Gmail-Original-Message-ID: <CACNAnaGg5jMBXk1nOnn6wMpbOcFBEJopPDr6QJBTA4660HNTkw@mail.gmail.com>
Message-ID: <CACNAnaGg5jMBXk1nOnn6wMpbOcFBEJopPDr6QJBTA4660HNTkw@mail.gmail.com>
Subject: Re: svn commit: r334226 - head/lib/libpmcstat/pmu-events
To: Bryan Drewery <bdrewery@freebsd.org>
Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, 
 svn-src-head@freebsd.org
Content-Type: text/plain; charset="UTF-8"
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Jun 2018 03:12:10 -0000

On Fri, May 25, 2018 at 4:46 PM, Bryan Drewery <bdrewery@freebsd.org> wrote:
> Author: bdrewery
> Date: Fri May 25 21:46:07 2018
> New Revision: 334226
> URL: https://svnweb.freebsd.org/changeset/base/334226
>
> Log:
>   Cleanup style
>
> Modified:
>   head/lib/libpmcstat/pmu-events/Makefile
>
> Modified: head/lib/libpmcstat/pmu-events/Makefile
> ==============================================================================
> --- head/lib/libpmcstat/pmu-events/Makefile     Fri May 25 20:42:28 2018        (r334225)
> +++ head/lib/libpmcstat/pmu-events/Makefile     Fri May 25 21:46:07 2018        (r334226)
> @@ -1,9 +1,10 @@
>  # $FreeBSD$
>
> -PROG=jevents
> -SRCS=jevents.c jsmn.c json.c
> +PROG=  jevents
> +SRCS=  jevents.c jsmn.c json.c
>  CFLAGS+= -Wno-cast-qual
> -.PATH: ${.CURDIR}
> -build-tools: jevents
>  MAN=
> +
> +build-tools: jevents
> +
>  .include <bsd.prog.mk>
>

Hi Bryan,

Something about this appears to be subtly wrong, but I can't quite pin
down what. I'm getting a failure in the lib32 build of libpmc:

sh: ./pmu-events/jevents: not found

My observations are that ${OBJDIR}/lib/libpmc/pmu-events/jevents
exists, as does ${SRCTOP}/lib/libpmc/pmu-events/jevents.
${OBJDIR}/obj-lib32/lib/libpmc, OTOH, only contains _INCSINS.meta and
libpmc_events.c.meta. I'm guessing this is the problem- that
obj-lib32/... doesn't have the built jevents, but it's not obvious to
me why this is the case.