From nobody Sun Jul 17 17:57:19 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4LmCV746jSz4Wtnb; Sun, 17 Jul 2022 17:57:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LmCV73V4Wz42t2; Sun, 17 Jul 2022 17:57:19 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1658080639; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=immm9U+yP0aY41ZT0a1kUKc6kNkIIxkOgUUiIPh+V94=; b=gZYUb7kFuHExhF6DBewMxH201duqUkDHjr1ZpWEbn/sKbEIwtwBRvyrdxTH661NPVgiBtJ 6LP4/BbSumX7fADlja53qJLVP+vlFQ1RgY5DsMsctmu6MFTJ3pCi4zyiRpm0U7hzxdwLxi PJR18Wo1/UInr7AeSYps5+Bb58jKQon9iKWmHT7To84AUueYRLTMNmz7cuIhh6JkO0P79J dRVrjkr+h6Q3D71I1f1o5MHs1rkfz+UfFeHRNnlPdkDPT16reLHVLbO293m9XUoBjXCx9v xCfpdzn6yVjJ6eIbecQaA/V7+5dXNo57hlK9GRk9vkh34n8s8HacmSJVxPIosw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4LmCV72JqSz18Hc; Sun, 17 Jul 2022 17:57:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 26HHvJSi043305; Sun, 17 Jul 2022 17:57:19 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 26HHvJ5g043304; Sun, 17 Jul 2022 17:57:19 GMT (envelope-from git) Date: Sun, 17 Jul 2022 17:57:19 GMT Message-Id: <202207171757.26HHvJ5g043304@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Dimitry Andric Subject: git: fb0493d55998 - main - Fix clang 15 warning in cxgbe List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: fb0493d55998eeb9f062b15b40924ff722f3eba5 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1658080639; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=immm9U+yP0aY41ZT0a1kUKc6kNkIIxkOgUUiIPh+V94=; b=VqFmOwspzokWp6XTY9rWN2VnkuhWeTXaVtWYVentSg8otf7MDYhSZIKXUTbJz0bsp3onLl apIESfwOd17kLnOUbZBktc+/c/+MBomZJAWSXdgh+RCOZcMZryGPBBrN5sagTHii6ZS8IG O4ZSLAfzm8UTkuPTASLkbF0P4NiUVqNJXZ1czpzGEgUivpAyTcUKbXdXJetwBSX7qXCsmX xpaIcdOt4+UgMdBhYRNV5G6aj00l0zQtWvNyfuzFuNhpicogI7RdWzBf+9LC0K/pLBkm50 KysLiFnUIWFSSGDQZS5nzxfYz49Gyjce72Wy5cCf27gWTvhOO8UL3TMBY8vFFg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1658080639; a=rsa-sha256; cv=none; b=YY2ew3EdlK7fmzJR/AOTP5pZcWulOfdBtsXfq4Q6tDscOt6Q0eRF9sEbrtCckWX9kIe9aX AejIRr2I0YEPMymG5ho5PB1gSBnblzXa8E5ch9ox0PHPzXZQ2KZX7NqR9em/nW7ftd1lMG FpdT8nhVDihjPWR2wKSkGuAMPkDQLGlJ33H/yWoArElSj/c3B90Cp+8CMNvoWpp6FegB3U zQ5Y+gIVxtbPD3I9LbkdrhnxgJxxGh+JrxBbkEllANuMVkR8r5N9tt8xiQlyIaRGcCN5T1 8JogBRcIjd8IlKohttel81JRB4y2vNylYOeSEQQiXKeZoUGmqKoJDRxbQyXchQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by dim: URL: https://cgit.FreeBSD.org/src/commit/?id=fb0493d55998eeb9f062b15b40924ff722f3eba5 commit fb0493d55998eeb9f062b15b40924ff722f3eba5 Author: Dimitry Andric AuthorDate: 2022-07-16 19:19:51 +0000 Commit: Dimitry Andric CommitDate: 2022-07-17 17:57:03 +0000 Fix clang 15 warning in cxgbe Clang 15 warns: sys/dev/cxgbe/cudbg/cudbg_lib.c:2949:6: error: variable 'i' set but not used [-Werror,-Wunused-but-set-variable] int i = 0; ^ Apparently 'i' was meant as the current retry counter, but '1' was used in the while loop comparison instead, making the loop potentially infinite, if 'busy' never gets reset. MFC after: 3 days Reviewed by: np Differential Revision: https://reviews.freebsd.org/D35834 --- sys/dev/cxgbe/cudbg/cudbg_lib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/cxgbe/cudbg/cudbg_lib.c b/sys/dev/cxgbe/cudbg/cudbg_lib.c index dcbcb24807b9..feded8e75863 100644 --- a/sys/dev/cxgbe/cudbg/cudbg_lib.c +++ b/sys/dev/cxgbe/cudbg/cudbg_lib.c @@ -2950,7 +2950,7 @@ static int check_busy_bit(struct adapter *padap) int retry = 10; int status = 0; - while (busy & (1 < retry)) { + while (busy && i < retry) { val = t4_read_reg(padap, A_CIM_HOST_ACC_CTRL); busy = (0 != (val & CUDBG_CIM_BUSY_BIT)); i++;