From owner-p4-projects@FreeBSD.ORG Thu Sep 27 19:29:26 2007 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id EE60D16A473; Thu, 27 Sep 2007 19:29:25 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B359F16A469; Thu, 27 Sep 2007 19:29:25 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.freebsd.org (Postfix) with ESMTP id 3307713C459; Thu, 27 Sep 2007 19:29:25 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.8p) with ESMTP id 211740145-1834499 for multiple; Thu, 27 Sep 2007 15:28:04 -0400 Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l8RJT7d5039168; Thu, 27 Sep 2007 15:29:11 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: "Kip Macy" Date: Thu, 27 Sep 2007 15:28:48 -0400 User-Agent: KMail/1.9.6 References: <200709262040.l8QKe8FL074297@repoman.freebsd.org> <200709261742.04531.jhb@freebsd.org> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200709271528.48811.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Thu, 27 Sep 2007 15:29:11 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/4414/Thu Sep 27 14:04:10 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: Perforce Change Reviews , Kip Macy Subject: Re: PERFORCE change 126835 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Sep 2007 19:29:26 -0000 On Thursday 27 September 2007 03:18:10 pm Kip Macy wrote: > It is in there, it just doesn't seem to do the trick :-/. Note that there was a recent bug fix in HEAD that fixed a race where if you were using a callout that rescheduled itself and didn't do an explicit callout_stop() while holding the lock but just did a callout_drain(), then the callout could remain scheduled. The latest commit to kern_timeout.c should fix this though. > -Kip > > On 9/26/07, John Baldwin wrote: > > On Wednesday 26 September 2007 04:40:08 pm Kip Macy wrote: > > > http://perforce.freebsd.org/chv.cgi?CH=126835 > > > > > > Change 126835 by kmacy@kmacy_home:ethng on 2007/09/26 20:40:03 > > > > > > increase delay in shutdown to avoid destroying the port lock > > > before the last call to the tick handler > > > > > > Affected files ... > > > > > > .. //depot/projects/ethng/src/sys/dev/cxgb/cxgb_main.c#21 edit > > > > > > Differences ... > > > > > > ==== //depot/projects/ethng/src/sys/dev/cxgb/cxgb_main.c#21 (text+ko) ==== > > > > > > @@ -1023,7 +1023,7 @@ > > > > > > ether_ifdetach(p->ifp); > > > printf("waiting for callout to stop ..."); > > > - DELAY(10000); > > > + DELAY(100000); > > > printf("done\n"); > > > > Umm, what about callout_drain()? That's its purpose. > > > > -- > > John Baldwin > > > -- John Baldwin