From owner-freebsd-current@FreeBSD.ORG Sat May 10 20:04:52 2014 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 67BEB7D5 for ; Sat, 10 May 2014 20:04:52 +0000 (UTC) Received: from mail-ve0-x22c.google.com (mail-ve0-x22c.google.com [IPv6:2607:f8b0:400c:c01::22c]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 21FA63A5 for ; Sat, 10 May 2014 20:04:52 +0000 (UTC) Received: by mail-ve0-f172.google.com with SMTP id oz11so6910991veb.17 for ; Sat, 10 May 2014 13:04:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=7HsOBCh2Jt4bxA4KDfxOpxVM5sYmM/lNs+jmbhQ/mNE=; b=zsJQaAO/lCdNVRd7yIuW5dEDSU29vr7EngbLsVFq9qrBKRGKa5iZ0BY7o9Op1O0/N0 9LY3tUN9A93zRwl2qZB31V0Ce1qVuI4uCXPhjGEME2rxNi4ObvM48/qc1q17aMISUH+4 TKXcT0xigwiTZzGExii/gF0kmwfuPxSlGzsV/XZSOl0crQLxedwAGDkhkPNdaWI/Eytd o3xcutxEIKW60eUAxZ/88nF5TaO0W5Y59+6V2Pos/8smq/PqckaM3PoOC28wZp/+xGhy cRnR66cbe00Sg1ufDnfYQZMKhi3LfSG1d98IZtjv5sW0KTXoPG2z+hr0SxCC4mu1AcvB YtKg== MIME-Version: 1.0 X-Received: by 10.58.74.38 with SMTP id q6mr14003354vev.7.1399752291260; Sat, 10 May 2014 13:04:51 -0700 (PDT) Received: by 10.220.239.84 with HTTP; Sat, 10 May 2014 13:04:51 -0700 (PDT) In-Reply-To: References: Date: Sat, 10 May 2014 16:04:51 -0400 Message-ID: Subject: Re: delete-old issue with src.opts.mk From: Thomas Hoffmann To: Warner Losh Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.18 Cc: freebsd-current X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 May 2014 20:04:52 -0000 On Sat, May 10, 2014 at 3:54 PM, Warner Losh wrote: > > On May 10, 2014, at 9:45 AM, Thomas Hoffmann wrote: > > > The other night I built a new -CURRENT at r265728. At delete-old it ask= ed > > me if I wanted to "remove /usr/share/mk/src.opts.mk?" I said yes. > > Subsequently an upgrade attempt for virtualbox-ose-4.3.10_1 failed with= a > > "missing src.opts.mk " error. > > I=E2=80=99ve fixed that. > > > Last night I built a new -CURRENT at 265793. At delete-old it asked me > if I > > wanted to "remove /usr/share/mk/src.opts.mk?"again. I said no. > Subsequently > > an upgrade for virtualbox-ose-4.3.10_1 succeded. > > You should say yes. > > > Three questions: > > 1. Why is delete-old repeatedly asking me if I want to remove > /usr/share/mk/ > > src.opts.mk? > > It seems to keep getting installed. It shouldn=E2=80=99t be now that I=E2= =80=99ve got > things ironed out. > > > 2. Why is delete-old asking me if I want to remove something that is > > required to build ports, well at least one port? I did not try to build > any > > other ports, so maybe it was just a virtualbox-ose issue? > > It isn=E2=80=99t required to build ports. Well, it was for a couple of da= ys due to > a bug, but I=E2=80=99ve fixed that bug. > > > 3. Should I keep src.opts.mk at delete-old or remove it? > > Remove it. It should ask you at most one more time. > > > I saw some discussion about src.opts.mk, but it centered around the use > of > > WITHOUT_NIS, which is not my issue. > > Yea. I understand. The WITHOUT_NIS was a different, and subtle, bug that = I > fixed as well. > > My advise: update to the tip of head, buildworld, install world, > delete-old (making sure you say =E2=80=98yes=E2=80=99) and then try virtu= albox-ose build > again. It should just work. If it doesn=E2=80=99t then send in a bug repo= rt since I > missed something when I fixed nvidia and cuse builds. > > Thanks for the report. I hope I can get this all ironed out for you. I > think I have already, but the build system is rather fragile, I=E2=80=99m= coming to > discover, and used in several non-obvious use cases that seem obvious aft= er > the bug report comes in=E2=80=A6 Sorry these slipped through the cracks i= n my > testing... > > Warner Thanks for the response. I'll follow your advice above when I build -CURRENT again tonight. No apology necessary. I build a new -CURRENT nearly every night and expect to run into a glitch every now and again. -Tom