From owner-svn-src-head@FreeBSD.ORG Sun Oct 19 03:49:41 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 3D44CD8A; Sun, 19 Oct 2014 03:49:41 +0000 (UTC) Received: from mail-wi0-x230.google.com (mail-wi0-x230.google.com [IPv6:2a00:1450:400c:c05::230]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 817CDFE0; Sun, 19 Oct 2014 03:49:40 +0000 (UTC) Received: by mail-wi0-f176.google.com with SMTP id hi2so4674447wib.3 for ; Sat, 18 Oct 2014 20:49:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=kkFdCSuFxh4yXQqI0QtfdwGVFn1JxN16fidWhkY2d+A=; b=o4Bh4DDUEIkM5uS6D+C1fg2ULOnMfIfuY3gmgt8rPz5GOPyoIKVkPjBxUdvQEs7cFv ji3lhPhUzhzOpgzsFvzNorfnFDoW1Z3v5/e0zr74dqKW91e79iTCQIXBOq+CNgOawc1z NvdF6SPRw2XSfM5lUrJlLiyt+r3TSkHNmVQyjuu/nv1Mf4SuUvXxj11Bwm/l931IXvX4 bcYKDddml+cJW1uyEiXn12T/vIX3f40gv5GX/BxlvqxUs4bBSGJc09gx7xbJv+indiJZ EYLtcsLJjw08lPcokH070FNr54bi74EobesY7NdL102GFtJxKjNmmWNQLisRb0icmRj4 lfhA== MIME-Version: 1.0 X-Received: by 10.180.74.4 with SMTP id p4mr9980394wiv.20.1413690578706; Sat, 18 Oct 2014 20:49:38 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.216.106.136 with HTTP; Sat, 18 Oct 2014 20:49:38 -0700 (PDT) In-Reply-To: <20141019032038.GA41067@onelab2.iet.unipi.it> References: <201410181936.s9IJaCwu018930@svn.freebsd.org> <20141019032038.GA41067@onelab2.iet.unipi.it> Date: Sat, 18 Oct 2014 20:49:38 -0700 X-Google-Sender-Auth: QxpruMivWBLyjwhLdlZkNaxz0Uk Message-ID: Subject: Re: svn commit: r273266 - in head: lib/libkvm sys/compat/freebsd32 sys/kern sys/sys From: Adrian Chadd To: Luigi Rizzo Content-Type: text/plain; charset=UTF-8 Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Oct 2014 03:49:41 -0000 On 18 October 2014 20:20, Luigi Rizzo wrote: > On Sat, Oct 18, 2014 at 07:36:12PM +0000, Adrian Chadd wrote: >> Author: adrian >> Date: Sat Oct 18 19:36:11 2014 >> New Revision: 273266 >> URL: https://svnweb.freebsd.org/changeset/base/273266 >> >> Log: >> Update the ULE scheduler + thread and kinfo structs to use int for cpuid >> rather than u_char. >> >> To try and play nice with the ABI, the u_char CPU ID values are clamped >> at 254. The new fields now contain the full CPU ID, or -1 for no cpu. > > This causes the following error with gcc: > > cc1: warnings being treated as errors > /usr/home/luigi/FreeBSD/head/sys/kern/kern_intr.c: In function 'intr_setaffinity': > /usr/home/luigi/FreeBSD/head/sys/kern/kern_intr.c:378: warning: comparison is always true due to limited range of data type > *** Error code 1 > > I suppose we can use NOCPU_OLD, or cast. Hah, good catch! No, we need to convert that use of u_char to int. I'll do it when I get home. Thanks! -a