From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Aug 29 14:20:24 2006 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3611216A4DA for ; Tue, 29 Aug 2006 14:20:24 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id B47F843D53 for ; Tue, 29 Aug 2006 14:20:23 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k7TEKNXD074310 for ; Tue, 29 Aug 2006 14:20:23 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k7TEKN0j074309; Tue, 29 Aug 2006 14:20:23 GMT (envelope-from gnats) Resent-Date: Tue, 29 Aug 2006 14:20:23 GMT Resent-Message-Id: <200608291420.k7TEKN0j074309@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Yen-Shuo Su Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6A49A16A4DA for ; Tue, 29 Aug 2006 14:15:23 +0000 (UTC) (envelope-from michael@factory.findbook.tw) Received: from factory.findbook.tw (ecowork.com.tw [59.124.230.82]) by mx1.FreeBSD.org (Postfix) with ESMTP id D187C43D46 for ; Tue, 29 Aug 2006 14:15:22 +0000 (GMT) (envelope-from michael@factory.findbook.tw) Received: from factory.findbook.tw (localhost.ecowork.com.tw [127.0.0.1]) by factory.findbook.tw (8.13.6/8.13.6) with ESMTP id k7TCB88E010302 for ; Tue, 29 Aug 2006 20:11:09 +0800 (CST) (envelope-from michael@factory.findbook.tw) Received: (from root@localhost) by factory.findbook.tw (8.13.6/8.13.6/Submit) id k7TCB8rS010301; Tue, 29 Aug 2006 20:11:08 +0800 (CST) (envelope-from michael) Message-Id: <200608291211.k7TCB8rS010301@factory.findbook.tw> Date: Tue, 29 Aug 2006 20:11:08 +0800 (CST) From: Yen-Shuo Su To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/102644: devel/p5-Decision-ACL: fix wrong decision when using zero as field value X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Yen-Shuo Su List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Aug 2006 14:20:24 -0000 >Number: 102644 >Category: ports >Synopsis: devel/p5-Decision-ACL: fix wrong decision when using zero as field value >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Tue Aug 29 14:20:23 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Yen-Shuo Su >Release: FreeBSD 6.1-STABLE i386 >Organization: Ecowork Inc. >Environment: 6.1-STABLE FreeBSD 6.1-STABLE #0: Sat Jun 10 03:53:35 CST 2006 >Description: This perl module will return wrong decision when using zero as field value >How-To-Repeat: use zero as rule value or field value >Fix: files/patch-ACL.pm: *** ACL.pm Sat Jul 28 09:18:58 2001 --- ACL.pm Fri Jul 28 17:32:18 2006 *************** *** 132,138 **** foreach my $control_field (@{ $self->ControlFields() }) { ! next if $args->{$control_field}; croak "Cannot run ACL, missing control field in arguments to RunACL() ($control_field)\n"; } return 1; --- 132,138 ---- foreach my $control_field (@{ $self->ControlFields() }) { ! next if defined($args->{$control_field}); croak "Cannot run ACL, missing control field in arguments to RunACL() ($control_field)\n"; } return 1; files/patch-ACL-Rules.pm: *** ACL/Rule.pm Tue Jul 10 02:06:13 2001 --- ACL/Rule.pm Tue Aug 29 20:05:40 2006 *************** *** 120,130 **** print STDERR "$field control (".$field_value.")->" if $self->DEBUG_LEVEL();; return ACL_RULE_UNCONCERNED if( ! $field_value ne $args->{$field} ! && $field_value && $field_value ne 'ALL' && $args->{$field} ne 'ALL' ! && $args->{$field}); print STDERR " 1\n" if $self->DEBUG_LEVEL();; } --- 120,130 ---- print STDERR "$field control (".$field_value.")->" if $self->DEBUG_LEVEL();; return ACL_RULE_UNCONCERNED if( ! defined($field_value) && $field_value ne 'ALL' + && defined($args->{$field}); && $args->{$field} ne 'ALL' ! && $field_value ne $args->{$field}); print STDERR " 1\n" if $self->DEBUG_LEVEL();; } >Release-Note: >Audit-Trail: >Unformatted: