From owner-freebsd-testing@FreeBSD.ORG Fri Jun 6 18:07:21 2014 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 485C77A7 for ; Fri, 6 Jun 2014 18:07:21 +0000 (UTC) Received: from mail-qa0-f49.google.com (mail-qa0-f49.google.com [209.85.216.49]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0B4A92E7E for ; Fri, 6 Jun 2014 18:07:20 +0000 (UTC) Received: by mail-qa0-f49.google.com with SMTP id cm18so4345966qab.8 for ; Fri, 06 Jun 2014 11:07:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:from:date:message-id:subject :to:content-type; bh=lPw3BCo/HrkWr/w6fCVcsgGiUsxrvsVzFnRw2w0qsUE=; b=LUnjsb6Kci849wjCsBL4o+Dy6pHzsQxmIX64iUFwN+0Js/GdLVu7DSdmuD/5U7YHDt jGTr6Gcd4sV41eiBBYtgu9SsMsQ1OQZEkANYt1q5Mtj0fcnrgXGtP9yXFF/f95JosIQX 5GV+xV/68OXslABlZV7CBmrVI10/fKm6/aRuimIf2LjC8MGU/B5Oph/jFPgz/TVjqGYn 9oI1dCFkD+5ZahklR0MDgFYPUa7cWWL5rJu4W7BK3z8+w9UUTwIEEIl2JDNC8fO96Iov gcOI/PV5QbrMpX/GrArToW2k89m9ttkWZXAfhObaNB/N3xNmP7NRI+tUJRIm3CAAxQG7 n1BA== X-Gm-Message-State: ALoCoQmTGBWc+B9H82Ypctfhw5EkU1M21Rp3nQ42RGywEhMkTSgDRvmNFU9alamKdiwPveAsDOuq X-Received: by 10.224.11.70 with SMTP id s6mr11135804qas.65.1402078034546; Fri, 06 Jun 2014 11:07:14 -0700 (PDT) MIME-Version: 1.0 Sender: jmmv@meroh.net Received: by 10.96.83.99 with HTTP; Fri, 6 Jun 2014 11:06:54 -0700 (PDT) X-Originating-IP: [2620:0:1003:1021:fd73:211d:1f18:17ea] From: Julio Merino Date: Fri, 6 Jun 2014 14:06:54 -0400 X-Google-Sender-Auth: res89YEKmPG1xNO58irj6sPmO4k Message-ID: Subject: Turning atf-sh into a private binary To: "freebsd-testing@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jun 2014 18:07:21 -0000 Hello, Just as we turned libatf-c and libatf-c++ into private libraries with r266650, I am going to do the same with the "shell library". I.e. I am going to move atf-sh from /usr/bin into /usr/libexec so that nobody can depend on atf-sh without intentionally doing so. Effectively, this turns all of atf into a "private" component of the base system, as it should be. The whole point of this change is to prevent people depending on atf-sh inadvertently: they will still be able to do so by using the binary from /usr/libexec (just as they can link against libraries in /usr/lib/private), but then they should understand that they are depending on internal implementation details that can change at will. I consider this to be a prerequisite for enabling WITH_TESTS by default given that moving the binary afterwards would be trickier. If you want to take a look: https://phabric.freebsd.org/D187 However, I plan to commit this *today* after I confirm the change working. The reason is to ride the UPDATING warning that I just committed with r267172 so that users don't have to clean their object trees twice in quick succession. Apologies for not giving enough time to review upfront, and yell if you think this is a horrible idea! Thanks