Date: Tue, 18 Jun 2013 00:40:39 GMT From: Geraud CONTINSOUZAS <geraud@gcu.info> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/179666: [PATCH] Fix graphics/graphviz with WITH_PERL Message-ID: <201306180040.r5I0edd8019211@oldred.freebsd.org> Resent-Message-ID: <201306180050.r5I0o0Q5093624@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 179666
>Category: ports
>Synopsis: [PATCH] Fix graphics/graphviz with WITH_PERL
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Tue Jun 18 00:50:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator: Geraud CONTINSOUZAS
>Release: FreeBSD 9.1-STABLE
>Organization:
>Environment:
>Description:
Long story short : the config/config_perl.pl file has changed significantly in the tarball and while the patch applies, the resulting file fails to run correctly under a recent perl (at least on 5.14). As a result the Perl bindings are not built (let alone packaged) when the PERL option is active.
The port will build fine but `make package` will report the missing files and fail.
>How-To-Repeat:
cd /usr/ports/graphics/graphviz; make
[x] PERL
make package
>Fix:
See attached patch (while there, I made some slight changes to silence a warning about future deprecation).
Patch attached with submission follows:
--- files/patch-config_perl.pl.orig 2013-06-18 11:16:49.000000000 +1100
+++ files/patch-config_perl.pl 2013-06-18 11:19:36.000000000 +1100
@@ -1,9 +1,14 @@
---- config/config_perl.pl.orig 2008-07-14 14:54:04.000000000 +0200
-+++ config/config_perl.pl 2009-03-15 11:08:29.000000000 +0100
-@@ -11,5 +11,5 @@
+--- config/config_perl.pl.orig 2013-02-15 00:27:39.000000000 +1100
++++ config/config_perl.pl 2013-06-18 11:18:34.000000000 +1100
+@@ -11,10 +11,9 @@
print "-I$archlib/CORE";
}
if ($ARGV[0] eq "PERL_INSTALL_DIR") {
-- print "$Config{vendorarch}"
-+ print "$Config{sitearch}"
- }
+-
+ my $d;
+
+- foreach $d qw(installvendorarch vendorarch installsitearch sitearch) {
++ foreach $d ( qw(installvendorarch vendorarch installsitearch sitearch) ) {
+ if (exists($Config{$d}) and defined($Config{$d}) and
+ ($Config{$d} ne '') ) {
+ print "$Config{$d}";
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201306180040.r5I0edd8019211>