From owner-freebsd-current@freebsd.org Wed May 18 23:56:00 2016 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 540FBB41021 for ; Wed, 18 May 2016 23:56:00 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 35F8A1488 for ; Wed, 18 May 2016 23:56:00 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mailman.ysv.freebsd.org (Postfix) id 353B6B41020; Wed, 18 May 2016 23:56:00 +0000 (UTC) Delivered-To: current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 34E05B4101F for ; Wed, 18 May 2016 23:56:00 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-oi0-f52.google.com (mail-oi0-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 052041487 for ; Wed, 18 May 2016 23:55:59 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-oi0-f52.google.com with SMTP id k142so103497378oib.1 for ; Wed, 18 May 2016 16:55:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :date:message-id:subject:from:to:cc; bh=kps/+VZYwBIz1Hg2A2OtzP1m1UID5wXr4fiEMI8tiUA=; b=H0TBTynNNUzZMp/ZXOYwrNFAGwOk5vLdMM6iTZ0FCwyJq3LkaTS0HcwfpJQ0HvcKQs uSLNVoBD/sazMw6wO3oKf05zvJfKpj5hgQtYZ05AWsVBYHm8WGCfQ6v30OgzH/iZUxRk DpdmOK0Bj4WckRhqhQmKbxO3XJqj/IEViS/Nt0e1S7GwGHPb1//I04etBcCA8BpsQHxg v+ASbxCVmbC6DNoxtyHPo26ZCrX6LDRyWZBmQqPy6unc9bPBYyg6o9oMfBCFUbOo5Okx OvPy3m55SWsVr92b5eEltRSPH5UAhnaidabM5H+ZBgsMoGc8VcpHuRylMSchiJIsNr0c PdHw== X-Gm-Message-State: AOPr4FUgno3MXAwliD5CqwH38h9ENmW+6JZLsgQztgzVnHVGRXyinLKjS61VBIHkLRSkKw== X-Received: by 10.202.95.68 with SMTP id t65mr6233296oib.7.1463615350768; Wed, 18 May 2016 16:49:10 -0700 (PDT) Received: from mail-ig0-f179.google.com (mail-ig0-f179.google.com. [209.85.213.179]) by smtp.gmail.com with ESMTPSA id sl9sm3027859oeb.10.2016.05.18.16.49.10 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 May 2016 16:49:10 -0700 (PDT) Received: by mail-ig0-f179.google.com with SMTP id bi2so105091800igb.0 for ; Wed, 18 May 2016 16:49:10 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.50.4.101 with SMTP id j5mr552165igj.8.1463615350174; Wed, 18 May 2016 16:49:10 -0700 (PDT) Reply-To: cem@FreeBSD.org Received: by 10.36.205.70 with HTTP; Wed, 18 May 2016 16:49:10 -0700 (PDT) In-Reply-To: <15379a54-3e6e-2c2c-b41c-8def3af65bad@capeaugusta.com> References: <15379a54-3e6e-2c2c-b41c-8def3af65bad@capeaugusta.com> Date: Wed, 18 May 2016 16:49:10 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: r299512 breaks dhclient on some networks From: Conrad Meyer To: Ian FREISLICH Cc: current Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 May 2016 23:56:00 -0000 Hey Ian, r299512 incorrectly encoded client identifiers because I misunderstood the intent of the sizeof()-scaled client_id. I reverted that change and replaced it with r300174, which I believe fixes the first overrun more correctly. (Coverity may still complain about CID 1305550, but I don't believe it's valid for 'hlen' to exceed sizeof(hw_addr.haddr).) Thanks, Conrad On Wed, May 18, 2016 at 3:49 PM, Ian FREISLICH wrote: > Hi > > I cannot for the life of me figure out why the change in r299512 breaks > DHCP on one network I use but not on another network. > > The only clue I can find is that the request whose response is ignored > has the following client ID: > 1:6:0:22:5f:70:a1:df > > The request whose response is use has this client ID: > 1:0:22:5f:70:a1:df > > Here's a dhcpdump of the request/offer that gets ignored. > > --------------------------------------------------------------------------- > > TIME: 2016-05-18 18:46:39.134 > IP: 0.0.0.0 (00:22:5f:70:a1:df) > 255.255.255.255 (ff:ff:ff:ff:ff:ff) > OP: 1 (BOOTPREQUEST) > HTYPE: 1 (Ethernet) > HLEN: 6 > HOPS: 0 > XID: 92a34fc3 > SECS: 0 > FLAGS: 0 > CIADDR: 0.0.0.0 > YIADDR: 0.0.0.0 > SIADDR: 0.0.0.0 > GIADDR: 0.0.0.0 > CHADDR: 00:22:5f:70:a1:df:00:00:00:00:00:00:00:00:00:00 > SNAME: . > FNAME: . > OPTION: 53 ( 1) DHCP message type 1 (DHCPDISCOVER) > OPTION: 61 ( 8) Client-identifier 01:06:00:22:5f:70:a1:df > OPTION: 12 ( 3) Host name zen > OPTION: 55 ( 9) Parameter Request List 1 (Subnet mask) > 28 (Broadcast address) > 2 (Time offset) > 121 (Classless Static Route) > 3 (Routers) > 15 (Domainname) > 6 (DNS server) > 12 (Host name) > 119 (Domain Search) > > --------------------------------------------------------------------------- > > TIME: 2016-05-18 18:46:39.134 > IP: 10.0.0.1 (4c:5e:0c:62:4f:82) > 10.0.0.80 (00:22:5f:70:a1:df) > OP: 2 (BOOTPREPLY) > HTYPE: 1 (Ethernet) > HLEN: 6 > HOPS: 0 > XID: 92a34fc3 > SECS: 0 > FLAGS: 0 > CIADDR: 0.0.0.0 > YIADDR: 10.0.0.80 > SIADDR: 10.0.0.1 > GIADDR: 0.0.0.0 > CHADDR: 00:22:5f:70:a1:df:00:00:00:00:00:00:00:00:00:00 > SNAME: . > FNAME: . > OPTION: 53 ( 1) DHCP message type 2 (DHCPOFFER) > OPTION: 54 ( 4) Server identifier 10.0.0.1 > OPTION: 51 ( 4) IP address leasetime 259200 (3d) > OPTION: 1 ( 4) Subnet mask 255.255.255.0 > OPTION: 3 ( 4) Routers 10.0.0.1 > OPTION: 6 ( 4) DNS server 10.0.0.1 > --------------------------------------------------------------------------- > > > And here's the request/offer that works (with the r299512 backed out) > > --------------------------------------------------------------------------- > > TIME: 2016-05-18 18:35:33.817 > IP: 10.0.0.220 (00:22:5f:70:a1:df) > 255.255.255.255 (ff:ff:ff:ff:ff:ff) > OP: 1 (BOOTPREQUEST) > HTYPE: 1 (Ethernet) > HLEN: 6 > HOPS: 0 > XID: 866cfd85 > SECS: 4 > FLAGS: 0 > CIADDR: 0.0.0.0 > YIADDR: 0.0.0.0 > SIADDR: 0.0.0.0 > GIADDR: 0.0.0.0 > CHADDR: 00:22:5f:70:a1:df:00:00:00:00:00:00:00:00:00:00 > SNAME: . > FNAME: . > OPTION: 53 ( 1) DHCP message type 3 (DHCPREQUEST) > OPTION: 50 ( 4) Request IP address 10.0.0.220 > OPTION: 61 ( 7) Client-identifier 01:00:22:5f:70:a1:df > OPTION: 12 ( 3) Host name zen > OPTION: 55 ( 9) Parameter Request List 1 (Subnet mask) > 28 (Broadcast address) > 2 (Time offset) > 121 (Classless Static Route) > 3 (Routers) > 15 (Domainname) > 6 (DNS server) > 12 (Host name) > 119 (Domain Search) > > --------------------------------------------------------------------------- > > TIME: 2016-05-18 18:35:33.817 > IP: 10.0.0.1 (4c:5e:0c:62:4f:82) > 10.0.0.220 (00:22:5f:70:a1:df) > OP: 2 (BOOTPREPLY) > HTYPE: 1 (Ethernet) > HLEN: 6 > HOPS: 0 > XID: 866cfd85 > SECS: 0 > FLAGS: 0 > CIADDR: 0.0.0.0 > YIADDR: 10.0.0.220 > SIADDR: 10.0.0.1 > GIADDR: 0.0.0.0 > CHADDR: 00:22:5f:70:a1:df:00:00:00:00:00:00:00:00:00:00 > SNAME: . > FNAME: . > OPTION: 53 ( 1) DHCP message type 5 (DHCPACK) > OPTION: 54 ( 4) Server identifier 10.0.0.1 > OPTION: 51 ( 4) IP address leasetime 259200 (3d) > OPTION: 1 ( 4) Subnet mask 255.255.255.0 > OPTION: 3 ( 4) Routers 10.0.0.1 > OPTION: 6 ( 4) DNS server 10.0.0.1 > --------------------------------------------------------------------------- > > > > -- > Ian Freislich > > > -- > > > Cape Augusta Digital Properties, LLC a Cape Augusta Company > > *Breach of confidentiality & accidental breach of confidentiality * > > This email and any files transmitted with it are confidential and intended > solely for the use of the individual or entity to whom they are addressed. > If you have received this email in error please notify the system manager. > This message contains confidential information and is intended only for the > individual named. If you are not the named addressee you should not > disseminate, distribute or copy this e-mail. Please notify the sender > immediately by e-mail if you have received this e-mail by mistake and > delete this e-mail from your system. If you are not the intended recipient > you are notified that disclosing, copying, distributing or taking any > action in reliance on the contents of this information is strictly > prohibited. > _______________________________________________ > freebsd-current@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"