From owner-svn-src-head@FreeBSD.ORG Thu Sep 6 21:50:27 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id F106A1065672 for ; Thu, 6 Sep 2012 21:50:26 +0000 (UTC) (envelope-from jos@catnook.com) Received: from mail-ey0-f182.google.com (mail-ey0-f182.google.com [209.85.215.182]) by mx1.freebsd.org (Postfix) with ESMTP id 2C9CE8FC14 for ; Thu, 6 Sep 2012 21:50:25 +0000 (UTC) Received: by eaak11 with SMTP id k11so799845eaa.13 for ; Thu, 06 Sep 2012 14:50:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-gm-message-state; bh=oXKWPh7/gBcUIEbTa1oLYJHgxLIPVueMLYzwEEesQKo=; b=V5amesYq+QmJ/1qVO360M3coSPa2bjafhB49XfHtdidbd9xkLM1vyfmQ3AIrYlBkbh bSlurbEIikAlgbfnyYKuhULRllH2ALn05cPST38YsK/eaOQw+MK/TXl0LkmAYL6ZR86x EQo9kZ2S5pPrgC2L3acA7JWGeyIrWrO0P7WliXGdNBvMccg7PDZyMX3TGqS35E6N3vRa fGI8itVSaRGEwM6uO2WYNzyJED9KMRr1ziFoKihjpKqYJpkLkK+8XVG1cNhuvEMOJKRr +LbAZIBY471UZpy9qzasqXqueRGK/83aRt+LIy6L1okXMRj7Nbm/G+QnFS4zqRjJ3v3i GcDw== MIME-Version: 1.0 Received: by 10.14.218.134 with SMTP id k6mr5218536eep.14.1346968224813; Thu, 06 Sep 2012 14:50:24 -0700 (PDT) Received: by 10.14.174.72 with HTTP; Thu, 6 Sep 2012 14:50:24 -0700 (PDT) In-Reply-To: <201209061459.q86Exr56038506@svn.freebsd.org> References: <201209061459.q86Exr56038506@svn.freebsd.org> Date: Thu, 6 Sep 2012 14:50:24 -0700 Message-ID: From: Jos Backus To: Josh Paetzel X-Gm-Message-State: ALoCoQkhycqmAiOK/Bc/6DykwQApzmmb1vZDGYnebwitAjYpVTx88nQ5BeR8zQmX7SVJ9gLvineJ Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r240165 - head/usr.sbin/pc-sysinstall/backend X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Sep 2012 21:50:27 -0000 On Thu, Sep 6, 2012 at 7:59 AM, Josh Paetzel wrote: > Modified: head/usr.sbin/pc-sysinstall/backend/functions-bsdlabel.sh > > ============================================================================== > --- head/usr.sbin/pc-sysinstall/backend/functions-bsdlabel.sh Thu Sep 6 > 13:54:01 2012 (r240164) > +++ head/usr.sbin/pc-sysinstall/backend/functions-bsdlabel.sh Thu Sep 6 > 14:59:53 2012 (r240165) > ... > FOUNDPARTS="1" > + USEDAUTOSIZE=0 > > # Lets read in the config file now and setup our partitions > if [ "${_pType}" = "gpt" ] ; then > @@ -245,7 +278,15 @@ setup_gpart_partitions() > > if [ "$SIZE" = "0" ] > then > - SOUT="" > + if [ $USEDAUTOSIZE -eq 1 ] ; then > Style question: if $USEDAUTOSIZE is treated as a boolean value, why not use `true' and `false' instead of `1' and `0'? No need to make shell code look like C code. That way one can write: if $USEDAUTOSIZE; then Jos -- Jos Backus jos at catnook.com