From owner-cvs-all@FreeBSD.ORG Wed Jan 9 20:42:21 2008 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 52BBE16A41B; Wed, 9 Jan 2008 20:42:21 +0000 (UTC) (envelope-from sam@errno.com) Received: from ebb.errno.com (ebb.errno.com [69.12.149.25]) by mx1.freebsd.org (Postfix) with ESMTP id 2329113C4E7; Wed, 9 Jan 2008 20:42:21 +0000 (UTC) (envelope-from sam@errno.com) Received: from trouble.errno.com (trouble.errno.com [10.0.0.248]) (authenticated bits=0) by ebb.errno.com (8.13.6/8.12.6) with ESMTP id m09KgKEc093342 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 9 Jan 2008 12:42:20 -0800 (PST) (envelope-from sam@errno.com) Message-ID: <478531AC.5030303@errno.com> Date: Wed, 09 Jan 2008 12:42:20 -0800 From: Sam Leffler User-Agent: Thunderbird 2.0.0.9 (X11/20071125) MIME-Version: 1.0 To: Peter Jeremy References: <200801081908.m08J8wIs094059@repoman.freebsd.org> <200801082039.18671.max@love2party.net> <20080109170850.GA27993@dragon.NUXI.org> <4785058B.1050507@errno.com> <20080109201424.GA4969@server.vk2pj.dyndns.org> In-Reply-To: <20080109201424.GA4969@server.vk2pj.dyndns.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-DCC-sonic.net-Metrics: ebb.errno.com; whitelist Cc: Max Laier , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, obrien@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet6 frag6.c icmp6.c in6.c in6_ifattach.c in6_pcb.c in6_proto.c in6_rmx.c in6_src.c ip6_input.c ip6_mroute.c ip6_output.c mld6.c nd6.c nd6_nbr.c nd6_rtr.c raw_ip6.c udp6_usrreq.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jan 2008 20:42:21 -0000 Peter Jeremy wrote: > On Wed, Jan 09, 2008 at 09:34:03AM -0800, Sam Leffler wrote: > >> I observe that netbsd does these sorts of changes in sweeps over the tree >> and w/ multiple people involved to review each other's work. I'd be more >> confident if I saw commits like this include a "Reviewed by:" line. >> > > For this sort of commit, it should also be possible to check that you > haven't broken anything by cmp(1)ing the .o files or manually preprocessing > and diffing the preprocessed files. > For this specific case md5 checksums of the resulting .o files should work. However some committers have a history of making changes like this that either break the build (w/o a quick followup to correct the problem) or introduce subtle issues that aren't found until much later. Hence my request (removed by obrien) that people do changes like this when they are actively working on a section of code. Drive-by commits like this frequently do more harm than good. Sam