From owner-cvs-src@FreeBSD.ORG Sat Oct 27 09:22:26 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A482116A41B; Sat, 27 Oct 2007 09:22:26 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.freebsd.org (Postfix) with ESMTP id 1059D13C465; Sat, 27 Oct 2007 09:22:25 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.14.1/8.14.1) with ESMTP id l9R9MEMe053518; Sat, 27 Oct 2007 13:22:14 +0400 (MSD) (envelope-from ache@nagual.pp.ru) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nagual.pp.ru; s=default; t=1193476934; bh=cCgrH4Fa8lFMmhIcQql2AC7qYu2jM++VLE8Yp0b EQyc=; l=1645; h=Date:From:To:Cc:Subject:Message-ID: Mail-Followup-To:References:MIME-Version:Content-Type: Content-Disposition:In-Reply-To:User-Agent; b=Bh5rLLc9zwEpTYe1K3ia pl1K3SohhRFVnBdUTqHBfyuPJIXEVLlhrLERXuB1BPCGJNJ/nzECG7bUlRdUeKNJELX nu1jhiJ+ow+gWeCXH13BtSTZOcfa94acM9msHiAiNV0zf/25JGAUvEWsX5vRmIwE83T ar9z6lHbm9BYUPlfM= Received: (from ache@localhost) by nagual.pp.ru (8.14.1/8.14.1/Submit) id l9R9MD2o053517; Sat, 27 Oct 2007 13:22:14 +0400 (MSD) (envelope-from ache) Date: Sat, 27 Oct 2007 13:22:13 +0400 From: Andrey Chernov To: Rong-en Fan Message-ID: <20071027092213.GA53271@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Rong-en Fan , Scott Long , John Baldwin , src-committers@freebsd.org, d@delphij.net, Robert Watson , imp@freebsd.org, cvs-src@freebsd.org References: <200710150951.l9F9pUm7026506@repoman.freebsd.org> <20071025233536.B99770@fledge.watson.org> <472120E8.90504@samsco.org> <200710261144.34645.jhb@freebsd.org> <472217C2.8020800@samsco.org> <6eb82e0710260954m73b3f17bq2c72a4cdb597640e@mail.gmail.com> <6eb82e0710270130o5557efew95f62aef8035d209@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6eb82e0710270130o5557efew95f62aef8035d209@mail.gmail.com> User-Agent: Mutt/1.5.16 (2007-06-09) Cc: Scott Long , src-committers@freebsd.org, d@delphij.net, John Baldwin , cvs-src@freebsd.org, Robert Watson , imp@freebsd.org Subject: Re: cvs commit: src/lib/libc/locale utf8.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Oct 2007 09:22:26 -0000 On Sat, Oct 27, 2007 at 04:30:30PM +0800, Rong-en Fan wrote: > On 10/27/07, Rong-en Fan wrote: > [...] > > I admit that I really did a very bad abi damage on libc. I have been > > working on it and > > removing those inline __* functions in _ctype.h help. It can be upgraded and > > also downgraded without problems. Without those inline stuffs, > > buildworld+installworld > > time difference is less than 60 seconds, which looks good. I will post the > > patch after some more tests. > > > > As for RELENG_7 and HEAD, I'm not 100% sure whether we should restore > > the compatibility as 1) 7.0 is not released yet, 2) we don't promise > > anything in > > HEAD branch. However, if most people think get rid of inline stuffs and > > have libc compatibility are nice, then we do the same for those two branches. > > After some tests, the patch is at > > http://people.freebsd.org/~rafan/ctype-abi-fix-6.diff > > Let me describe this patch in more details. Fist, we actually > compile those inline functions as real functions in > lib/libc/locale/nomacro.c if _EXTERNAL_CTYPE_INLINES_ is defined. > I make 4 inline functions that use the __mb_sb_limit symbol, > which break the compatibility, always compiled as real functions. > I also considered that moving those inlined function in another > C file, but I think it would make the source codes diverse > among 6 and 7/8. As a small improvement, we can skip __isctype() from this list too and just hardcode 128 there, i.e.: return (_c < 0 || _c >= 128) ... since default locale never define anything above 128. -- http://ache.pp.ru/