From owner-svn-src-head@FreeBSD.ORG Wed Feb 11 22:15:38 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 56CA51065706; Wed, 11 Feb 2009 22:15:38 +0000 (UTC) (envelope-from sam@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 449EC8FC0A; Wed, 11 Feb 2009 22:15:38 +0000 (UTC) (envelope-from sam@FreeBSD.org) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id n1BMFcGT037453; Wed, 11 Feb 2009 22:15:38 GMT (envelope-from sam@svn.freebsd.org) Received: (from sam@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id n1BMFcFP037452; Wed, 11 Feb 2009 22:15:38 GMT (envelope-from sam@svn.freebsd.org) Message-Id: <200902112215.n1BMFcFP037452@svn.freebsd.org> From: Sam Leffler Date: Wed, 11 Feb 2009 22:15:38 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r188499 - head/sys/dev/ath/ath_hal/ar5416 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Feb 2009 22:15:39 -0000 Author: sam Date: Wed Feb 11 22:15:37 2009 New Revision: 188499 URL: http://svn.freebsd.org/changeset/base/188499 Log: gcc 4.3.2 examines getLowerUpperIndex() and concludes that it's not guaranteed to initialize its two last arguments. Therefore, there is a warning in the subsequent caller ar5416FillVpdTable(), which doesn't initialize those arguments. Change getLowerUpperIndex() to assign values to indexL and indexR even in the case of assertion failure. Submitted by: Pavel Roskin Modified: head/sys/dev/ath/ath_hal/ar5416/ar5416_reset.c Modified: head/sys/dev/ath/ath_hal/ar5416/ar5416_reset.c ============================================================================== --- head/sys/dev/ath/ath_hal/ar5416/ar5416_reset.c Wed Feb 11 20:36:17 2009 (r188498) +++ head/sys/dev/ath/ath_hal/ar5416/ar5416_reset.c Wed Feb 11 22:15:37 2009 (r188499) @@ -2710,6 +2710,7 @@ getLowerUpperIndex(uint8_t target, uint8 } } HALASSERT(0); + *indexL = *indexR = 0; return AH_FALSE; }