From owner-freebsd-arch Tue Oct 31 20:14:54 2000 Delivered-To: freebsd-arch@freebsd.org Received: from rover.village.org (rover.village.org [204.144.255.49]) by hub.freebsd.org (Postfix) with ESMTP id 9179A37B4CF; Tue, 31 Oct 2000 20:14:37 -0800 (PST) Received: from billy-club.village.org (billy-club.village.org [10.0.0.3]) by rover.village.org (8.11.0/8.11.0) with ESMTP id eA14ETn27612; Tue, 31 Oct 2000 21:14:32 -0700 (MST) (envelope-from imp@billy-club.village.org) Received: from billy-club.village.org (localhost [127.0.0.1]) by billy-club.village.org (8.11.1/8.8.3) with ESMTP id eA14EiV42330; Tue, 31 Oct 2000 21:14:44 -0700 (MST) Message-Id: <200011010414.eA14EiV42330@billy-club.village.org> To: John Baldwin Subject: Re: Like to commit my diskprep Cc: arch@FreeBSD.org, obrien@FreeBSD.org In-reply-to: Your message of "Tue, 31 Oct 2000 19:52:13 PST." References: Date: Tue, 31 Oct 2000 21:14:43 -0700 From: Warner Losh Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG In message John Baldwin writes: : Actually, Jordan has already committed them to current. And they don't : violate layering. The only layering violation we have is dangerously : dedicated mode when done from disklabel via 'disklabel ad0 auto' instead : of 'fdisk -I ad0 ; disklabel ad0s1 auto', which Matt's fixes actually : let us do now. Now that I'm less mobile, I've been able to take a close look at the code. It looks fairly good and will make diskprep's life easier in many ways. The new ioctl isn't strictly necessary, but does make life easier for disklabel to figure things out. I was able to divine this information from fdisk's output... I also see why I thought Matt's code added an mbr on top of that, which was a pilot error on my part. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message