From owner-svn-src-all@FreeBSD.ORG Mon Oct 18 14:37:05 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DFA3E106566C; Mon, 18 Oct 2010 14:37:05 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id B04E88FC0A; Mon, 18 Oct 2010 14:37:05 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 4E81646B0C; Mon, 18 Oct 2010 10:37:05 -0400 (EDT) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 4C64D8A009; Mon, 18 Oct 2010 10:37:04 -0400 (EDT) From: John Baldwin To: Marius Strobl Date: Mon, 18 Oct 2010 10:03:12 -0400 User-Agent: KMail/1.13.5 (FreeBSD/7.3-CBSD-20100819; KDE/4.4.5; amd64; ; ) References: <201010171646.o9HGks2U038501@svn.freebsd.org> In-Reply-To: <201010171646.o9HGks2U038501@svn.freebsd.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201010181003.13045.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (bigwig.baldwin.cx); Mon, 18 Oct 2010 10:37:04 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.96.3 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-1.9 required=4.2 tests=BAYES_00 autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on bigwig.baldwin.cx Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r213985 - head/sys/sparc64/sparc64 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2010 14:37:06 -0000 On Sunday, October 17, 2010 12:46:54 pm Marius Strobl wrote: > Author: marius > Date: Sun Oct 17 16:46:54 2010 > New Revision: 213985 > URL: http://svn.freebsd.org/changeset/base/213985 > > Log: > - In oneshot-mode it doesn't make sense to try to compensate the clock > drift in order to achieve a more stable clock as the tick intervals may > vary in the first place. In fact I haven't seen this code kick in when > in oneshot-mode so just skip it in that case. > - There's no need to explicitly stop the (S)TICK counter in oneshot-mode > with every tick as it just won't trigger again with the (S)TICK compare > register set to a value in the past (with a wrap-around once every ~195 > years of uptime at 1.5 GHz this isn't something we have to worry about > in practice). > - Given that we'll disable interrupts completely anyway there's no > need to enter critical sections. This last is not entirely true. The purpose of the critical section is to prevent the kernel from preempting to the softclock swi thread until all of the hardclock handler has finished execution. Thus, places that actually actually call hardclock() should probably still be wrapped in a critical section. -- John Baldwin