From owner-svn-src-head@freebsd.org Tue Feb 26 17:52:51 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 201B81520F50; Tue, 26 Feb 2019 17:52:51 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A7D3D6AC23; Tue, 26 Feb 2019 17:52:50 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id 7ACCF3C475F; Tue, 26 Feb 2019 17:52:48 +0000 (UTC) Date: Tue, 26 Feb 2019 17:52:48 +0000 From: Brooks Davis To: "K. Macy" Cc: Matt Macy , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers Subject: Re: svn commit: r344487 - in head/sys: conf gnu/gcov Message-ID: <20190226175248.GF47081@spindle.one-eyed-alien.net> References: <201902232114.x1NLE0cH085345@repo.freebsd.org> <20190225175809.GB47081@spindle.one-eyed-alien.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ZRyEpB+iJ+qUx0kp" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Rspamd-Queue-Id: A7D3D6AC23 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.97)[-0.970,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Feb 2019 17:52:51 -0000 --ZRyEpB+iJ+qUx0kp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 25, 2019 at 05:11:26PM -0800, K. Macy wrote: > > We had a brief discussion of this commit within a subset of core. This > > addition of GPLv2 code is fine as the code is easily removal to a module > > (per kmoore@) should the day come that we're read to evict all GPL code. >=20 > I don't execute the ctors until coverage is enabled because I have to > manually find the symbols. The linker doesn't actually generate a ctor > section for functions in text.startup in spite of what Juniper's > linker commit would lead one to believe - presumably they have a > private linker script in addition to a private gcov port. Thus, it > really could just work fine as a module. Nonetheless, everything to be > profiled needs to be compiled with instrumentation, so separating it > out makes very little sense to me. Although, I suppose ctfconvert + > dtrace module is somewhat analogous. >=20 > > The modest increase in activation energy for that task seems worth it > > for the short-term gains of reduced integration cost (this code will > > greatly improve our ZFS-on-Linux test coverage.) > > > > Rod rightly points out that we haven't accepted SPDX tags alone as > > license statements. The standard GPL v2.0 boiler plate should be added > > to this file along side the tag. >=20 > I've copied the full copyright attribution that is in the > corresponding files on Linux. Is there some reason why FreeBSD > requires the files to be inflated with the full license text where the > original lacks it? We're not asking for the full text, just the standard block: // This program is free software; you can redistribute it and/or // modify it under the terms of the GNU General Public License // as published by the Free Software Foundation; either version 2 // of the License, or (at your option) any later version. //=20 // This program is distributed in the hope that it will be useful, // but WITHOUT ANY WARRANTY; without even the implied warranty of // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the // GNU General Public License for more details. //=20 // You should have received a copy of the GNU General Public License // along with this program; if not, write to the Free Software // Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA // 02110-1301, USA. This is from: https://www.gnu.org/licenses/old-licenses/gpl-2.0.en.html#SEC4 We're not currently using SPDX to include licenses, largely because OSI completely and utterly botched BSD licenses. Fixing this is WAY down the list of things on core's plate. Unless someone takes ownership here, I don't see this changing any time soon. > > An additional issue is that the a warning tag was not added to > > sys/conf/files. A warning along the lines of: > > > > warning "kernel contains GPLv2 licensed GCOV" > > > > needs to be added. >=20 > Yup. >=20 > > > > This commit needed more through review. >=20 > How would this be achieved:? I had several people on the review and no > one had substantive feedback. For GPL stuff, add #core to the reviewers list and feel free to drop us an email to make sure we see it promptly. -- Brooks --ZRyEpB+iJ+qUx0kp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJcdXzvAAoJEKzQXbSebgfAWQsH/3kANY+XUPrSUi9UpaCjb+py aNvyxKkR5rpsWjvS4Se+bE0IpYF1kowjSIkx6Cx+ia5K4gMhRxP95DmUJ03dvUwZ FHd341kGv+g74Q3SJ7ISaWLhD8TkcH04gbWGO6bPGO0UnKrBJOUbjp5kq26Yk130 v3jNP+dshdMZwTDIycxCI1V2jAwSAukyHRVs671xNyEyietsrMgv1cBlZVa/nJxy i0Kr8OIILOSj2e5/zibJD3y1PzKWD51ap3Gbvj8UIrQjASgppJMWXOKsqcs71O3t oFSV70GcNdmrxSeAc/QDXrdjXBcxD+NGn/WmilMpIP3vVODWZsPPeLZa+l9pOkU= =Xbn1 -----END PGP SIGNATURE----- --ZRyEpB+iJ+qUx0kp--