From owner-svn-src-all@FreeBSD.ORG Tue Feb 10 08:15:52 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 55B799F4; Tue, 10 Feb 2015 08:15:52 +0000 (UTC) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id BA98C616; Tue, 10 Feb 2015 08:15:51 +0000 (UTC) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.14.9/8.14.9) with ESMTP id t1A8FcfJ037688 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 10 Feb 2015 10:15:38 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.9.2 kib.kiev.ua t1A8FcfJ037688 Received: (from kostik@localhost) by tom.home (8.14.9/8.14.9/Submit) id t1A8Fcvw037686; Tue, 10 Feb 2015 10:15:38 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 10 Feb 2015 10:15:38 +0200 From: Konstantin Belousov To: Rui Paulo Subject: Re: svn commit: r278479 - in head: etc sys/kern Message-ID: <20150210081538.GK42409@kib.kiev.ua> References: <201502092313.t19NDpoS083043@svn.freebsd.org> <20150209232826.GJ42409@kib.kiev.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.0 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on tom.home Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Rui Paulo X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Feb 2015 08:15:52 -0000 On Mon, Feb 09, 2015 at 06:35:55PM -0800, Rui Paulo wrote: > On Feb 9, 2015, at 15:28, Konstantin Belousov wrote: > > Arguably, there should be a knob, probably sysctl, to turn the > > functionality off. I definitely do not want this on crash boxes used for > > userspace debugging. Even despite the example handler is inactive. > > OK, I can provide a sysctl knob. Seen that, thanks. > > >> + len = MAXPATHLEN * 2 + 5 /* comm= */ + 5 /* core= */ + 1; > > It is much cleaner to use static const char arrays for the names, > > and use sizeof() - 1 instead of hard-coding commented constants. > > OK. I was trying to avoid allocating >2k on the stack. Probably I was not clear enough. I do not suggest to change data allocation from malloc to automatic. I mean static const char comm_name[] = "comm="; and then use sizeof(comm_name) - 1 and comm_name instead of string literal. > > >> + data = malloc(len, M_TEMP, M_NOWAIT); > > Why is this allocation M_NOWAIT ? > > That should be M_WAITOK. > > >> + freepath = NULL; > >> + } > >> + if (vn_fullpath_global(td, vp, &fullpath, &freepath) != 0) > >> + goto out; > >> + snprintf(data, len, "%s core=%s", data, fullpath); > > This is weird, and highly depends on the implementation details, supplying > > the same string as target and source. IMO strcat(9) is enough there. > > OK, I'll change it to strcat. > > -- > Rui Paulo > >