Date: Mon, 12 Mar 2007 12:24:06 +0300 From: Eygene Ryabinkin <rea-fbsd@codelabs.ru> To: "Bruce M. Simpson" <bms@FreeBSD.org> Cc: rik@FreeBSD.org, freebsd-net@freebsd.org, glebius@FreeBSD.org, andre@FreeBSD.org, thompsa@FreeBSD.org Subject: Re: kern/109815: wrong interface identifier at pfil_hooks for vlans + if_bridge Message-ID: <20070312092406.GJ58523@codelabs.ru> In-Reply-To: <45ED900A.7050208@FreeBSD.org> References: <45E9F1E8.2000802@inse.ru> <20070304062203.GL80319@codelabs.ru> <E1HNbWw-000LoF-Bo@pobox.codelabs.ru> <45E9F1E8.2000802@inse.ru> <20070304160613.GN80319@codelabs.ru> <45EB4915.1090703@FreeBSD.org> <20070305145647.GT80319@codelabs.ru> <45EC3EFD.3000301@FreeBSD.org> <20070306073945.GR57456@codelabs.ru> <45ED900A.7050208@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Bruce, good day! Tue, Mar 06, 2007 at 04:00:10PM +0000, Bruce M. Simpson wrote: > Eygene Ryabinkin wrote: > >I am awfully sorry, but you're seem to be mistaken: > Thanks for clarifying this. That'll be because I didn't read if_bridge that > far. ;^) In my original message I was just looking at if_ethersubr.c. > > I need to make sure any changes which are made to if_bridge to deal with vlan > problems are incorporated into bms_netdev so that after I commit M_PROMISC, it > does the right thing. OK, after discuissing the problem for a while, Roman Kurakin (rik@) decided to modify my patch: it will not just blindly rewriting the interface in the mbuf, but will apply an extra check for the physical incoming interface before checking the other bridge members. So it will hopefully do no harm to anything that was worked before and will cure the problem I spotted. Speaking about vlan problems: the original problem is to do something with VLAN interfaces only because they are sharing the MAC of their physical parent. The problem itself is not VLAN-specific -- if there will be two physical interfaces with the same MACs and they will be bridged, the problem will still be here. Will drop you a letter when the patch will be ready. -- Eygene
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070312092406.GJ58523>