From nobody Tue Sep 20 15:38:01 2022 X-Original-To: freebsd-arch@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MX5KV4C4kz4cbrX for ; Tue, 20 Sep 2022 15:38:06 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-qv1-xf31.google.com (mail-qv1-xf31.google.com [IPv6:2607:f8b0:4864:20::f31]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MX5KT63m8z3jj5 for ; Tue, 20 Sep 2022 15:38:05 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: by mail-qv1-xf31.google.com with SMTP id s13so2261400qvq.10 for ; Tue, 20 Sep 2022 08:38:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=NeJhSD4D06+0X8Z9qqdoIJHoiawh+grckS1VL9ACVzI=; b=Eq6pq/CvtrRG6aYHGmcSX17NPbTJiUOIzieGjtPguzf7VYZeeDwFv+kzaK3fhA7FI5 yCSRgxoCbjK7xiEmib9m7Gpo+Eu3jr2o0VEpSYMUWy7kFmzUCDm4gu+iO557xxSoi7QD HLp48+JeFK266Pp2/U0a5Vk22gfTd3Do4kw8oBP8mjhQ8NnQxc2mHG0i/a1FCXQqPBBR DnINjR7IbyoYNYChznuZ7lYqXf/KMfzjDWDWrJoQy1YuXgMqrNj4nOVEBC/PyMj8TMmE Yd4oC8FTy3NBwHS1TiXbSR/Wc9gA/kirbWliBS5IE7Z1EgSDPV7JywDLaHW2qZkaGjZT xIsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=NeJhSD4D06+0X8Z9qqdoIJHoiawh+grckS1VL9ACVzI=; b=gQxaYanfeLT67OjK1QoEZs/SxoYMhKs+xBkHQGTVQGEFju2TEKcgRECzWS52nNXfNC eiW0gdiTnwwRxUlS4K7GqE6UH6Fr+cfbq65K4nplUjqlctBfQnTrnDbcC09MO9xZGHTT 3o/01iqL8QWfqsuSjhPMSNRwsMHguWAFgETi7WjDbGYhshkWMvyT0O/CSr6Scy9cXUpm uNzDJAQ1uK+ovmgqgw1f57IU8BEpp8Yp0NNZs2iLnB3xDmRoBABg02ApMht2BQXgAoB5 8DGsWoALitAOljK9rQFAsKgmthRDV5Ook8xtaIUrZ9Sz+m/qhdUSPlhCGzMAecz0SPWD ABgQ== X-Gm-Message-State: ACrzQf1PbWD+QupljKggpvDCffXwuRISQHMUlBH1Q+R08/bEDug/kSBT WaLGGM61cB90QWDVq0KuV+T1NjcVdHeWUw== X-Google-Smtp-Source: AMsMyM7ZyQz2cLzV2xyZMC+B5n+ftGCBuDVcr2C10r9vJS2vc3F8A7fmRvVO7IfZVR2qXA+EG0swMQ== X-Received: by 2002:a05:6214:5285:b0:474:69d7:c22b with SMTP id kj5-20020a056214528500b0047469d7c22bmr19977323qvb.97.1663688284263; Tue, 20 Sep 2022 08:38:04 -0700 (PDT) Received: from mutt-hbsd (pool-100-16-219-215.bltmmd.fios.verizon.net. [100.16.219.215]) by smtp.gmail.com with ESMTPSA id l27-20020a37f91b000000b006af3f3b385csm29667qkj.98.2022.09.20.08.38.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Sep 2022 08:38:02 -0700 (PDT) Date: Tue, 20 Sep 2022 11:38:01 -0400 From: Shawn Webb To: Warner Losh Cc: "freebsd-arch@freebsd.org" Subject: Re: Stlye(9) strengthen statements on not using K&R function definitions Message-ID: <20220920153801.wzsrphd2ychvfbgm@mutt-hbsd> X-Operating-System: FreeBSD mutt-hbsd 14.0-CURRENT-HBSD FreeBSD 14.0-CURRENT-HBSD X-PGP-Key: https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/blob/master/Shawn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc References: List-Id: Discussion related to FreeBSD architecture List-Archive: https://lists.freebsd.org/archives/freebsd-arch List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-arch@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="pol5wi4ctdp2w6ma" Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4MX5KT63m8z3jj5 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=hardenedbsd.org header.s=google header.b="Eq6pq/Cv"; dmarc=none; spf=pass (mx1.freebsd.org: domain of shawn.webb@hardenedbsd.org designates 2607:f8b0:4864:20::f31 as permitted sender) smtp.mailfrom=shawn.webb@hardenedbsd.org X-Spamd-Result: default: False [-5.10 / 15.00]; SIGNED_PGP(-2.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.999]; MID_RHS_NOT_FQDN(0.50)[]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; R_DKIM_ALLOW(-0.20)[hardenedbsd.org:s=google]; RCVD_TLS_LAST(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::f31:from]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; MLMMJ_DEST(0.00)[freebsd-arch@freebsd.org]; RCPT_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_SOME(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; DKIM_TRACE(0.00)[hardenedbsd.org:+]; TO_DN_SOME(0.00)[]; DMARC_NA(0.00)[hardenedbsd.org]; PREVIOUSLY_DELIVERED(0.00)[freebsd-arch@freebsd.org]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_EQ_ADDR_SOME(0.00)[] X-ThisMailContainsUnwantedMimeParts: N --pol5wi4ctdp2w6ma Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 26, 2022 at 10:31:17AM -0600, Warner Losh wrote: > Greetings >=20 > I've posted a review https://reviews.freebsd.org/D35945 which strengths > statements about K&R definitions and declarations: don't use them. Most of > the K&R code has been removed from the tree (ufs being the last straggler= ). > Future versions of the C standard will remove the K&R definitions and > declaration syntax. clang 15 will whine about this construct. >=20 > The time is ripe to move to language that suggests an outright prohibitio= n. >=20 > Comments about language? Make them in phabricator. > Comments about the idea? Reply here FYI: I did notice the other day that less(1) strictly uses K&R. --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/03A= 4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc --pol5wi4ctdp2w6ma Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAmMp3lIACgkQ/y5nonf4 4fqSSBAAiqr4euJb6XE8m5tp13ma8N9+dDNNe8ISE+27LUpKMA3HwSLROsCO1tHN 3hZnjAUwIWHVzrY4KRBYVK47v+CQtY/a77fem21rfwWElHNkcS2lv5ylKfic/XYj SodE5OW4GScbY0M9zYjh7k5ITIc+Hpo8w4G90e9WJZryEfwrW85aEuF5wiQ3qVCl H9Uh1t/cunRAdormwi/bmdHG/DV3N7PRa5LNduxJ+4bC13uN63aKsXzwAUKRvC2x CGntVV/fTCBTjyMAgM8JqGl0zoJ+l40H0+G3B+uUrNqq3k1IHTrSrTsR42eCPNVX 8fhhUQoN4j7GkGrvWqb4R1TweYFl2ImpJkqJYQCYj8mshMTlfXDtP5JiOjEAQB/i ZizVgfqEC0FkyvjwEU3zD2Wna1dNb9dUaerks3YC22r9qCemu1b4FFReUvyO57/y zkPPr/4ch+4KNA9SXF+URVIFAj2PZ+Q8akyPt+LgyO7AivnuoZTyrItDUGV68QHD dPHlM9BebNzkNF13317aT+y/QS8pjbLJ+uZSeXCKBv6SunCLhNsvjUR0G3kTduZq B8r+Gi9Xe7+FqJ5norY8YE0QjDkUw+7eFf2z9Q2xC5Ymkv00VhrPKFH2SyJykL8U Xq6fqFpEGJ+B17HIs0CCHgIsAoB5ryAXD0E86yuVVizQnw3Dj0c= =n9mf -----END PGP SIGNATURE----- --pol5wi4ctdp2w6ma--