Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 9 Sep 2004 09:29:13 -0500 (CDT)
From:      UDSD387 <root@techpc04.okladot.state.ok.us>
To:        <FreeBSD-gnats-submit@FreeBSD.org>
Cc:        riggs@rrr.de
Subject:   ports/71527: multimedia/mplayer compile bombs when enabling configure knob WITH_TREMOR=yes
Message-ID:  <20040909142913.C204E5CA8@techpc04.okladot.state.ok.us>
Resent-Message-ID: <200409091440.i89EeJZ0089745@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         71527
>Category:       ports
>Synopsis:       multimedia/mplayer compile bombs when enabling configure knob WITH_TREMOR=yes
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Sep 09 14:40:19 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator:     "Paul Seniura" <pdseniura@techie.com>
>Release:        FreeBSD 6.0-CURRENT i386
>Organization:
State of Okla. D.O.T.
>Environment:
System: FreeBSD techpc04.okladot.state.ok.us 6.0-CURRENT FreeBSD 6.0-CURRENT #0: Wed Sep 8 13:47:43 CDT 2004 root@techpc04.okladot.state.ok.us:/usr/obj/src/sys/IBM300SY_4BSD_Os i386


>Description:

The commit from PR 70959 added the knob WITH_TREMOR:

: vs          2004-08-26 07:52:37 UTC
: 
:   FreeBSD ports repository
: 
:   Modified files:
:     multimedia/mplayer   Makefile
:   Log:
:   Requested by Koop Mast:
:   - Correct detection of ogg theora codec
:   - Avoid accidently linking to libtremor if not explicitly forced by user
:     (important, therefore PORTREVISION bump!)
: 
:   PR:             ports/70959
:   Submitted by:   Thomas E. Zander (maintainer)
: 
:   Revision  Changes    Path
:   1.102     +24 -1     ports/multimedia/mplayer/Makefile

... so I decided to try it.

My build log shows:

[...]
--->  Upgrade of multimedia/mplayer started at: Wed, 01 Sep 2004 14:05:21 -0500
--->  Upgrading 'mplayer-gtk2-esound-0.99.5_1' to 'mplayer-gtk2-esound-0.99.5_2' (multimedia/mplayer)
--->  Build of multimedia/mplayer started at: Wed, 01 Sep 2004 14:05:21 -0500
--->  Building '/usr/ports/multimedia/mplayer'
===>  Building for mplayer-gtk2-esound-0.99.5_2
[...]
gmake -C libmpdemux
gmake[1]: Entering directory `/src/ports/multimedia/mplayer/work/MPlayer-1.0pre5/libmpdemux'
cc -c -I../libvo -I../../libvo -I/usr/X11R6/include -O -pipe -march=pentium2 -pipe -Os -march=pentium2 -O3 -ffast-math -fomit-frame-pointer  -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -I/usr/local/include/freetype2 -I/usr/local/include -DGDK_DISABLE_DEPRECATED -DGTK_DISABLE_DEPRECATED -I/usr/local/include/atk-1.0 -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/X11R6/include/gtk-2.0 -I/usr/X11R6/lib/gtk-2.0/include -I/usr/X11R6/include -I/usr/X11R6/include/pango-1.0 -I/usr/local/include/freetype2 -I/usr/local/include   -I../loader  -I/usr/local/include/freetype2 -I/usr/local/include -DGDK_DISABLE_DEPRECATED -DGTK_DISABLE_DEPRECATED -I/usr/local/include/atk-1.0 -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/X11R6/include/gtk-2.0 -I/usr/X11R6/lib/gtk-2.0/include -I/usr/X11R6/include -I/usr/X11R6/include/pango-1.0 -I/usr/local/include/freetype2 -I/usr/local/include       -o demux_ogg.o demux_ogg.c
demux_ogg.c: In function `demux_ogg_add_sub':
demux_ogg.c:220: warning: initialization from incompatible pointer type
demux_ogg.c: In function `demux_ogg_read_packet':
demux_ogg.c:323: warning: assignment from incompatible pointer type
demux_ogg.c:324: error: invalid operands to binary &
demux_ogg.c:345: warning: assignment from incompatible pointer type
demux_ogg.c:377: error: invalid operands to binary &
demux_ogg.c:381: error: invalid operands to binary &
demux_ogg.c:382: error: invalid operands to binary &
demux_ogg.c:383: warning: assignment from incompatible pointer type
demux_ogg.c:388: error: invalid operands to binary &
demux_ogg.c:395: error: invalid operands to binary |
demux_ogg.c: In function `demux_ogg_add_packet':
demux_ogg.c:498: error: invalid operands to binary &
demux_ogg.c:523: error: invalid operands to binary -
demux_ogg.c:524: error: invalid operands to binary -
demux_ogg.c: In function `demux_ogg_scan_stream':
demux_ogg.c:583: warning: initialization makes pointer from integer without a cast
demux_ogg.c:638: warning: initialization makes pointer from integer without a cast
demux_ogg.c: In function `demux_ogg_open':
demux_ogg.c:697: warning: assignment makes pointer from integer without a cast
demux_ogg.c:736: warning: passing arg 1 of `strncmp' from incompatible pointer type
demux_ogg.c:745: warning: passing arg 1 of `strncmp' from incompatible pointer type
demux_ogg.c:801: warning: passing arg 1 of `strncmp' from incompatible pointer type
demux_ogg.c:809: error: aggregate value used where an integer was expected
demux_ogg.c:809: error: aggregate value used where an integer was expected
demux_ogg.c:809: error: aggregate value used where an integer was expected
demux_ogg.c:809: error: aggregate value used where an integer was expected
demux_ogg.c:849: error: invalid operands to binary &
demux_ogg.c: In function `demux_ogg_fill_buffer':
demux_ogg.c:1036: warning: assignment makes pointer from integer without a cast
demux_ogg.c: In function `init_avi_with_ogg':
demux_ogg.c:1126: warning: assignment makes pointer from integer without a cast
demux_ogg.c: In function `demux_ogg_seek':
demux_ogg.c:1281: warning: initialization makes pointer from integer without a cast
gmake[1]: *** [demux_ogg.o] Error 1
gmake[1]: Leaving directory `/src/ports/multimedia/mplayer/work/MPlayer-1.0pre5/libmpdemux'
gmake: *** [libmpdemux/libmpdemux.a] Error 2
*** Error code 2

Stop in /src/ports/multimedia/mplayer.
** Command failed [exit code 1]: /usr/bin/script -qa /tmp/portupgrade1384.2 make
** Fix the problem and try again.
--->  Build of multimedia/mplayer ended at: Wed, 01 Sep 2004 14:05:25 -0500 (consumed 00:00:04)
--->  Upgrade of multimedia/mplayer ended at: Wed, 01 Sep 2004 14:05:25 -0500 (consumed 00:00:04)
[...]


Changing CFLAGS etc. does not help the problem.

This is actually A Known Problem[tm] ;) on other platforms
that are supported by the MPlayer project, not just/only BSD. 
Indeed the maillist archives at MPlayerHQ.hu show msgs going
back at least to January 2004 with this same exact problem.

I've recompiled and updated everything under the sun after
-Current's gcc was updated to gcc342.  I don't think gcc is to
blame either.

# ls -al /var/db/pkg/libtremor*
drwxr-xr-x  2 root  wheel       512 Sep  7 13:50 libtremor-1.0.2.021320041
total 20
-rw-r--r--  1 root  wheel     56 Aug  6 09:45 +COMMENT
-rw-r--r--  1 root  wheel    888 Aug  6 09:45 +CONTENTS
-rw-r--r--  1 root  wheel    137 Aug  6 09:45 +DESC
-r--r--r--  1 root  wheel  11209 Aug  6 09:45 +MTREE_DIRS
-rw-r--r--  1 root  wheel    132 Sep  9 05:44 +REQUIRED_BY

(I'm in the middle of updating KDE to 3.3.0, so some
of these dates will show being touched recently.)


>How-To-Repeat:

Set WITH_TREMOR=yes in /etc/make.conf or wherever, then
build the port normally.

Actually I have enabled almost every knob available in
the port-skeleton Makefile.


>Fix:

There may be some kind of conflict when almost all knobs
are enabled in this regard; but we really do need all the
support those knobs provide -- except for libtremor since
libvorbis is available and does work in its place.

This should be very easily reproducable: 
With almost all knobs enabled, all I did was prevent
defining WITH_TREMOR, and voila we don't see this problem.

So my workaround/fix is: 
Do not set WITH_TREMOR at all. 
Let the port use libvorbis instead if you need it.

If enabling libtremor support does show this bug on other
systems, I would ask the maintainer to please discourage
others wanting to use this knob by removing/commenting-out
the WITH_TREMOR logic in the port-skeleton Makefile and
forcing the configure switch --disable-tremor.

If anything, this PR is being logged to document the
problem, since other users will probably stumble upon it
when 5.3-Final comes out.

(The actual problem may be fixed in mplayer-CVS; I might
try compiling it later after KDE is finished, which may
not be 'til next week or later.  If the CVS _is_ fixed
in this regard, then the MPlayer team need to be
'encouraged' to put out another 'official prerelease'
with the fixes. ;) )


  --  thx, Paul Seniura
           System Specialist
           State of Okla. D.O.T.

>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040909142913.C204E5CA8>