From owner-svn-ports-all@FreeBSD.ORG Thu Nov 15 10:54:50 2012 Return-Path: Delivered-To: svn-ports-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9D397FA2; Thu, 15 Nov 2012 10:54:50 +0000 (UTC) (envelope-from flo@smeets.im) Received: from mail.solomo.de (mail.solomo.de [5.9.87.18]) by mx1.freebsd.org (Postfix) with ESMTP id 3D6398FC08; Thu, 15 Nov 2012 10:54:50 +0000 (UTC) Received: from cpos1.nexxtmobile.de (localhost [127.0.0.1]) by mail.solomo.de (Postfix) with ESMTP id 8E60CB9BB; Thu, 15 Nov 2012 11:54:49 +0100 (CET) X-Virus-Scanned: amavisd-new at nexxtmobile.de Received: from mail.solomo.de ([127.0.0.1]) by cpos1.nexxtmobile.de (cpos1.nexxtmobile.de [127.0.0.1]) (amavisd-new, port 10024) with LMTP id HK2zX2MOCfoN; Thu, 15 Nov 2012 11:54:44 +0100 (CET) Received: from bender.solomo.local (b2b-92-50-66-163.unitymedia.biz [92.50.66.163]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mail.solomo.de (Postfix) with ESMTPSA id E873FB9B4; Thu, 15 Nov 2012 11:54:43 +0100 (CET) Message-ID: <50A4C9F3.8040405@smeets.im> Date: Thu, 15 Nov 2012 11:54:43 +0100 From: Florian Smeets User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: =?ISO-8859-1?Q?Philippe_Aud=E9oud?= Subject: Re: svn commit: r307446 - head/www/xpi-colorfultabs References: <201211151016.qAFAGgQj064519@svn.freebsd.org> <20121115112221.ba4ce4e361a4fe5f627f0199@critical.ch> <50A4C343.7080501@smeets.im> <20121115103854.GA66564@FreeBSD.org> <20121115105027.GA19830@tuxaco.net> In-Reply-To: <20121115105027.GA19830@tuxaco.net> X-Enigmail-Version: 1.4.5 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Cc: svn-ports-head@FreeBSD.org, Emanuel Haupt , Alexey Dokuchaev , svn-ports-all@FreeBSD.org, ports-committers@FreeBSD.org, Alex Dupre X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Nov 2012 10:54:50 -0000 On 11/15/2012 11:50, Philippe Audéoud wrote: > On Thu, 15 Nov 2012, Alexey Dokuchaev wrote: > >> On Thu, Nov 15, 2012 at 11:26:11AM +0100, Florian Smeets wrote: >>> On 11/15/2012 11:22, Emanuel Haupt wrote: >>>> These two files are probably not needed. >>> >>> Yeah, i know. I saw them but decided to just add them to the plist, >>> rather than hacking up the Makefile with something to use find on the >>> WRKSRC and delete them. >>> >>> If anybody sees this as a problem, i can hack the Makefile to delete >>> them prior to installation. >> >> Yes, it is a problem. It makes us (FreeBSD) look like careless fools not >> even able (or giving a shit about) to keep crap out of the packages we ship. >> These things add up, regardless of how non-functional they might be, to the >> bad impression of us. Please try to make ports nice and clean, remove the >> crap, it's very easy: >> >> post-extract: >> # Remove the crap >> @${FIND} ${WRKSRC} -type f -name ... -delete >> >> Slighly longer for directories. >> >> ./danfe > > Agreed with danfe and you should drop a mail to upstream maintainer to > warn him about theses useless files! > Yes, you guys are right. I was sloppy. It's fixed now. Thanks. Someone might want to do a sweep though :) http://people.freebsd.org/~flo/DS_Store.txt Florian