Date: Thu, 15 Nov 2012 11:54:43 +0100 From: Florian Smeets <flo@smeets.im> To: =?ISO-8859-1?Q?Philippe_Aud=E9oud?= <jadawin@FreeBSD.org> Cc: svn-ports-head@FreeBSD.org, Emanuel Haupt <ehaupt@critical.ch>, Alexey Dokuchaev <danfe@FreeBSD.org>, svn-ports-all@FreeBSD.org, ports-committers@FreeBSD.org, Alex Dupre <ale@FreeBSD.org> Subject: Re: svn commit: r307446 - head/www/xpi-colorfultabs Message-ID: <50A4C9F3.8040405@smeets.im> In-Reply-To: <20121115105027.GA19830@tuxaco.net> References: <201211151016.qAFAGgQj064519@svn.freebsd.org> <20121115112221.ba4ce4e361a4fe5f627f0199@critical.ch> <50A4C343.7080501@smeets.im> <20121115103854.GA66564@FreeBSD.org> <20121115105027.GA19830@tuxaco.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 11/15/2012 11:50, Philippe Audéoud wrote:
> On Thu, 15 Nov 2012, Alexey Dokuchaev wrote:
>
>> On Thu, Nov 15, 2012 at 11:26:11AM +0100, Florian Smeets wrote:
>>> On 11/15/2012 11:22, Emanuel Haupt wrote:
>>>> These two files are probably not needed.
>>>
>>> Yeah, i know. I saw them but decided to just add them to the plist,
>>> rather than hacking up the Makefile with something to use find on the
>>> WRKSRC and delete them.
>>>
>>> If anybody sees this as a problem, i can hack the Makefile to delete
>>> them prior to installation.
>>
>> Yes, it is a problem. It makes us (FreeBSD) look like careless fools not
>> even able (or giving a shit about) to keep crap out of the packages we ship.
>> These things add up, regardless of how non-functional they might be, to the
>> bad impression of us. Please try to make ports nice and clean, remove the
>> crap, it's very easy:
>>
>> post-extract:
>> # Remove the crap
>> @${FIND} ${WRKSRC} -type f -name ... -delete
>>
>> Slighly longer for directories.
>>
>> ./danfe
>
> Agreed with danfe and you should drop a mail to upstream maintainer to
> warn him about theses useless files!
>
Yes, you guys are right. I was sloppy. It's fixed now. Thanks.
Someone might want to do a sweep though :)
http://people.freebsd.org/~flo/DS_Store.txt
Florian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?50A4C9F3.8040405>