From owner-svn-src-projects@FreeBSD.ORG Sun Aug 8 13:17:36 2010 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C52591065672; Sun, 8 Aug 2010 13:17:36 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-qy0-f175.google.com (mail-qy0-f175.google.com [209.85.216.175]) by mx1.freebsd.org (Postfix) with ESMTP id 445E98FC1B; Sun, 8 Aug 2010 13:17:35 +0000 (UTC) Received: by qyk11 with SMTP id 11so1363965qyk.13 for ; Sun, 08 Aug 2010 06:17:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type; bh=GkkCXcStj7oeRpVLyFlDd98sc9t//aB+FqR+xEhXLrk=; b=gDibSdZ9M7s/giF6TfvybxOuZwM5MQg4QJt+S5obSCsHoD5zjWo7mD7HSdfKsqMrGu r/u7D6WtIn82QoDCwfIsHP4ESggG/eX9aVCL7ycpiaYBN1AnJhgNDC9n+iuSeU4Jlz/M 1twLatPTTf1CmJX+5tfeVOjklxoWxrMbatsNQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; b=pjvmfvCRe5z2yRe5dnSlmwcvq7ScGVCIdLzzIdY3aN1caxVxmcfvKIW4LPoPd6vXsm CWvz86iETdTX7LpqI44ylWWedE+U5HmpelwNYLbtzM2fDBtvxC0ovQWGpUTvOg6ew9vT tzBc6zyM4T3087em4AywC8y9o57FlL7YWQSdY= MIME-Version: 1.0 Received: by 10.224.69.14 with SMTP id x14mr7569065qai.212.1281273455128; Sun, 08 Aug 2010 06:17:35 -0700 (PDT) Sender: asmrookie@gmail.com Received: by 10.229.251.6 with HTTP; Sun, 8 Aug 2010 06:17:35 -0700 (PDT) In-Reply-To: <20100808125531.GA40928@sandvine.com> References: <201008071739.o77HdM2Y009458@svn.freebsd.org> <20100808114725.GA34359@sandvine.com> <20100808125531.GA40928@sandvine.com> Date: Sun, 8 Aug 2010 15:17:35 +0200 X-Google-Sender-Auth: YfU1RwHip1-xt8HDxVTIZ4A5BTs Message-ID: From: Attilio Rao To: Ed Maste Content-Type: text/plain; charset=UTF-8 Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r211029 - projects/sv/sys/net X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Aug 2010 13:17:36 -0000 2010/8/8 Ed Maste : > On Sun, Aug 08, 2010 at 02:35:53PM +0200, Attilio Rao wrote: > >> 2010/8/8 Ed Maste : >> > On Sat, Aug 07, 2010 at 05:39:22PM +0000, Attilio Rao wrote: >> > >> >> Author: attilio >> >> Date: Sat Aug ??7 17:39:22 2010 >> >> New Revision: 211029 >> >> URL: http://svn.freebsd.org/changeset/base/211029 >> >> >> >> Log: >> >> ?? Add a tunable for nd_enable. >> >> ?? As long as TUNABLE_INT is discouraged, however, switch the type int -> long >> >> ?? and adjust accordingly the sysctl stubs. >> > >> > This doesn't really make sense as far as I can tell - and particularly >> > for sysctls, using a long can introduce 32-bit compat issues. ??I'd >> > prefer that this remain an int. >> > >> > What benefit does using a long provide in this case? >> >> Did you see the recent thread on hackers@ about it? >> If we choice to go with a direction on TUNABLES_* I'd prefer to follow it now. > > I just read it now, but I don't see any actual reason to prefer long in > that thread. Probabilly remove the comment would be the best thing then. I'm in favor of it. Attilio -- Peace can only be achieved by understanding - A. Einstein