From owner-svn-ports-all@FreeBSD.ORG Tue Dec 16 13:47:12 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 742102CD; Tue, 16 Dec 2014 13:47:12 +0000 (UTC) Received: from prod2.absolight.net (mx3.absolight.net [IPv6:2a01:678:2:100::25]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "plouf.absolight.net", Issuer "CAcert Class 3 Root" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 3197733E; Tue, 16 Dec 2014 13:47:12 +0000 (UTC) Received: from prod2.absolight.net (localhost [127.0.0.1]) by prod2.absolight.net (Postfix) with ESMTP id 4D9D9BDC2E; Tue, 16 Dec 2014 14:47:10 +0100 (CET) Received: from gw.in.absolight.net (gw-ecl.in.absolight.net [79.143.241.69]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "gw.in.absolight.net", Issuer "CA Cert Signing Authority" (not verified)) by prod2.absolight.net (Postfix) with ESMTPSA id 31A34BDC24; Tue, 16 Dec 2014 14:47:10 +0100 (CET) Received: from ogg.in.absolight.net (ogg.in.absolight.net [79.143.241.239]) by gw.in.absolight.net (Postfix) with ESMTP id B5DC86115; Tue, 16 Dec 2014 14:47:09 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by ogg.in.absolight.net (Postfix) with ESMTP id 1B91479B4036; Tue, 16 Dec 2014 14:47:09 +0100 (CET) Date: Tue, 16 Dec 2014 14:47:09 +0100 From: Mathieu Arnold To: Alex Kozlov Subject: Re: svn commit: r374800 - head/Mk/Uses Message-ID: <5B209A4BD7689CD74744CFA7@ogg.in.absolight.net> In-Reply-To: <20141216133802.GA27647@ravenloft.kiev.ua> References: <201412161206.sBGC6fa5045717@svn.freebsd.org> <54902709.9090801@marino.st> <71EBD6FD6D89266B6651554A@ogg.in.absolight.net> <20141216133802.GA27647@ravenloft.kiev.ua> X-Mailer: Mulberry/4.0.8 (Mac OS X) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Cc: svn-ports-all@freebsd.org, svn-ports-head@freebsd.FreeBSD.ORG, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Dec 2014 13:47:12 -0000 +--On 16 d=C3=A9cembre 2014 15:38:02 +0200 Alex Kozlov = wrote: | On Tue, Dec 16, 2014 at 01:41:26PM +0100, Mathieu Arnold wrote: |> +--On 16 d=C3=A9cembre 2014 13:35:21 +0100 John Marino |> wrote: |> | On 12/16/2014 13:06, Mathieu Arnold wrote: |> |> Author: mat |> |> Date: Tue Dec 16 12:06:40 2014 |> |> New Revision: 374800 |> |> URL: https://svnweb.freebsd.org/changeset/ports/374800 |> |> QAT: https://qat.redports.org/buildarchive/r374800/ |> |>=20 |> |> Log: |> |> ts=3D8, repeat after me, ts=3D8. |> |> =20 |> |> With hat: perl@ |> |> Sponsored by: Absolight |> |>=20 |> |> Modified: |> |> head/Mk/Uses/perl5.mk |> |>=20 |> |=20 |> | This is not just a perl thing. search for "ts=3D4" and other 4-space |> | tabs indicators in Mk, it's full of them (e.g. grep -nr "ts=3D4" |> | /usr/ports/Mk). If ts should be 8 across the board (and I think it |> | should be), then all of these need to be changes and then documented. |> Yes, it should, feel free to pitch in and provide patches to fix some |> other files :-) | Allow me to ask, why it should be 8 and not 4? Because a tabulation is 8 spaces. It should be consistent over the whole ports tree. --=20 Mathieu Arnold