From owner-freebsd-gnome@FreeBSD.ORG Mon Nov 29 02:14:49 2004 Return-Path: Delivered-To: freebsd-gnome@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C97D816A4CE; Mon, 29 Nov 2004 02:14:49 +0000 (GMT) Received: from creme-brulee.marcuscom.com (creme-brulee.marcuscom.com [24.172.16.118]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3586943D54; Mon, 29 Nov 2004 02:14:49 +0000 (GMT) (envelope-from marcus@marcuscom.com) Received: from shumai.marcuscom.com (shumai.marcuscom.com [192.168.1.4]) iAT2F0Ge011360; Sun, 28 Nov 2004 21:15:00 -0500 (EST) (envelope-from marcus@marcuscom.com) From: Joe Marcus Clarke To: Michael Johnson In-Reply-To: <997800CC-41A5-11D9-BAC8-000A958C81C6@ahze.net> References: <200411290158.05194.dejan.lesjak@ijs.si> <36850935-41A4-11D9-BAC8-000A958C81C6@ahze.net> <997800CC-41A5-11D9-BAC8-000A958C81C6@ahze.net> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-k1FgrY6Vce7WuTWYVOJU" Organization: MarcusCom, Inc. Date: Sun, 28 Nov 2004 21:14:34 -0500 Message-Id: <1101694474.49651.37.camel@shumai.marcuscom.com> Mime-Version: 1.0 X-Mailer: Evolution 2.0.2 FreeBSD GNOME Team Port cc: Dejan Lesjak cc: kris@freebsd.org cc: freebsd gnome Subject: Re: libxklavier and upcoming xorg 6.8.1 upgrade X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Nov 2004 02:14:49 -0000 --=-k1FgrY6Vce7WuTWYVOJU Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Sun, 2004-11-28 at 20:25 -0500, Michael Johnson wrote: > On Nov 28, 2004, at 8:20 PM, Michael Johnson wrote: >=20 > > > > On Nov 28, 2004, at 8:15 PM, Michael Johnson wrote: > > > >>> Having no imake, this part fails and configure then checks if it=20 > >>> needs > >>> additional flags for X. It already has -I${X11BASE}/include in=20 > >>> CPPFLAGS and > >>> -L${X11BASE}/lib in LDFLAGS in environment, so it concludes that it=20 > >>> doesn't > >>> need any and sets both $x_includes and $x_libraries to empty=20 > >>> strings. That > >>> would be otherwise fine and the thing would bild. Unfortunately, it=20 > >>> uses the > >>> value of $x_libraries to construct location of xkb specifications=20 > >>> without > >>> further checks, and there it fails. > >>> So for the solution: adding either=20 > >>> "--with-xkb-base=3D${X11BASE}/lib/X11/xkb" or > >>> "--x-includes=3D${X11BASE}/include --x-libraries=3D${X11BASE}/lib" to > >>> CONFIGURE_ARGS in ports Makefile should solve the problem. > >> > >> This brings up a good point, the lines in bsd.port.mk > >> > >> .if defined(USE_XLIB) > >> LIB_DEPENDS+=3D X11.6:${X_LIBRARIES_PORT} > >> # Add explicit X options to avoid problems with false positives in=20 > >> configure > >> .if defined(GNU_CONFIGURE) > >> CONFIGURE_ARGS+=3D--x-libraries=3D${X11BASE}/lib=20 > >> --x-includes=3D${X11BASE}/include > >> .endif > >> .endif > >> > >> Don't work with WITH_LIBTOOL_ since GNU_CONFIGURE is defined from=20 > >> bsd.autotools.mk > >> should the previous not be a part of bsd.autotools.mk? > > > > Or moved in bsd.port.mk so it works with bsd.autotools.mk ? >=20 > Like http://ahze.net/~ahze/bsd.port.mk.patch seems to work Yeah, this looks okay. I wonder if Kris can add this to pointyhat as part of the X.Org 6.8.1 build. If not, this should be turned into a PR for future testing. Joe --=20 PGP Key : http://www.marcuscom.com/pgp.asc --=-k1FgrY6Vce7WuTWYVOJU Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQBBqoYKb2iPiv4Uz4cRAlfHAJ4pLYD7/zcHIZjZcDmT04DBJfHXIACeK/tN RiGjPDGn4+8i9r5iLZZu3yI= =LIPq -----END PGP SIGNATURE----- --=-k1FgrY6Vce7WuTWYVOJU--