From owner-freebsd-bugs@freebsd.org  Sun Jan 17 05:50:46 2016
Return-Path: <owner-freebsd-bugs@freebsd.org>
Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 13606A6D990
 for <freebsd-bugs@mailman.ysv.freebsd.org>;
 Sun, 17 Jan 2016 05:50:46 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id DE6C91A8E
 for <freebsd-bugs@FreeBSD.org>; Sun, 17 Jan 2016 05:50:45 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u0H5ojwM035887
 for <freebsd-bugs@FreeBSD.org>; Sun, 17 Jan 2016 05:50:45 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 206326] mandoc  -r294113's parse assertion fd > 0 is failing:
 main's STDIN_FILENO use does not meet that criteria
Date: Sun, 17 Jan 2016 05:50:45 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: bin
X-Bugzilla-Version: 11.0-CURRENT
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Many People
X-Bugzilla-Who: markmi@dsl-only.net
X-Bugzilla-Status: New
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status bug_severity priority component assigned_to reporter
Message-ID: <bug-206326-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 17 Jan 2016 05:50:46 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D206326

            Bug ID: 206326
           Summary: mandoc  -r294113's parse assertion fd > 0 is failing:
                    main's STDIN_FILENO use does not meet that criteria
           Product: Base System
           Version: 11.0-CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Many People
          Priority: ---
         Component: bin
          Assignee: freebsd-bugs@FreeBSD.org
          Reporter: markmi@dsl-only.net

mandoc is crashing via an assert as of any build based on
contrib/madocml/main.c -r294113. The 2nd assert below is failing:

static void
parse(struct curparse *curp, int fd, const char *file)
{
        enum mandoclevel  rctmp;
        struct roff_man  *man;

        /* Begin by parsing the file itself. */

        assert(file);
        assert(fd > 0);
. . .

This is because:

int
main(int argc, char *argv[])
{
. . .
        if (argc < 1) {
                if (use_pager)
                        tag_files =3D tag_init();
                parse(&curp, STDIN_FILENO, "<stdin>");
        }

but STDIN_FILENO is zero:

# grep STDIN_FILENO /usr/include/*
/usr/include/roken-common.h:#ifndef STDIN_FILENO
/usr/include/roken-common.h:#define STDIN_FILENO 0
/usr/include/unistd.h:#define   STDIN_FILENO    0       /* standard input f=
ile
descriptor */

If main's parse call with STDIN_FILENO is to be valid then the assert needs=
 to
be more like:

        assert(fd >=3D 0);

(or an equivalent). The prior main.c revision (-r280025) used fd >=3D -1 fo=
r some
reason. That would not fail the assertion for STDIN_FILENO but would allow =
-1
without failing the assertion as well. (I've no clue why -1 was allowed back
then.)

--=20
You are receiving this mail because:
You are the assignee for the bug.=