Date: Mon, 15 May 2023 10:42:20 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Cy Schubert <cy@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-branches@freebsd.org Subject: Re: git: 24d6c5b19f8d - 2023Q2 - deskutils/xcalendar: Fix LLVM15 build Message-ID: <ZGIMjIHK7pGDq0%2BE@FreeBSD.org> In-Reply-To: <202305140525.34E5PWv0082197@gitrepo.freebsd.org> References: <202305140525.34E5PWv0082197@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, May 14, 2023 at 05:25:32AM +0000, Cy Schubert wrote:
> commit 24d6c5b19f8df4220d03f7cdd8f99071bcde7360
>
> deskutils/xcalendar: Fix LLVM15 build
>
> At a minimum fix an incompatible pointer to integer conversion flagged
> by LLVM15. While at it include stdlib.h in preparation for additional
> ...
> + if (sizeof(buf) == len) {
> + buf = XtRealloc(buf, len + 1);
> + }
> -+ buf[len] = NULL;
> ++ buf[len] = 0;
> +
Since buf is `char *', I guess '\0' would look better here.
> start = buf;
>
> --- a/deskutils/xcalendar/files/patch-xcalendar.h
> +++ b/deskutils/xcalendar/files/patch-xcalendar.h
> @@ -1,5 +1,5 @@
> ---- xcalendar.h.orig Sun Oct 1 12:21:42 1995
> -+++ xcalendar.h Mon Mar 12 20:54:02 2001
> +--- xcalendar.h.orig 1995-09-30 20:21:42.000000000 -0700
> ++++ xcalendar.h 2023-04-30 21:02:14.402254000 -0700
We try not to embed nanosecond precision and timezone in patches, ``make
makepatch'' generates correct patch headers for you.
./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ZGIMjIHK7pGDq0%2BE>