From owner-freebsd-bugs@freebsd.org Fri Feb 1 13:44:08 2019 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 762DA14B1F9B for ; Fri, 1 Feb 2019 13:44:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 0A2D48E86D for ; Fri, 1 Feb 2019 13:44:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id BD0FC14B1F99; Fri, 1 Feb 2019 13:44:07 +0000 (UTC) Delivered-To: bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 939D314B1F97 for ; Fri, 1 Feb 2019 13:44:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2812A8E86B for ; Fri, 1 Feb 2019 13:44:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 74AC41A93E for ; Fri, 1 Feb 2019 13:44:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x11Di6Kc070789 for ; Fri, 1 Feb 2019 13:44:06 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x11Di6AU070788 for bugs@FreeBSD.org; Fri, 1 Feb 2019 13:44:06 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 235380] gptzfsboot does not boot ZFS pool made from whole disks (regression) Date: Fri, 01 Feb 2019 13:44:06 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: reto.haeuptli@infinox.ch X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Feb 2019 13:44:08 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D235380 Bug ID: 235380 Summary: gptzfsboot does not boot ZFS pool made from whole disks (regression) Product: Base System Version: 12.0-RELEASE Hardware: amd64 OS: Any Status: New Severity: Affects Some People Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: reto.haeuptli@infinox.ch I used to boot zfs on whole disk(s) from a USB stick with a GPT partition scheme and gptzfsboot on it since FreeBSD version 9 on many testing machines and even production servers without any problems. With the release 12 this feature is broken.=20 I found the reason in the source code: In the file /head/stand/i386/libi386/biosdisk.c a regression was introduced in the revisions base r37271, base r337317. Its about detecting the correct number= of sectors/blocks for a block device. The change was introduced because a cert= ain device (Mediasonic HD3-U2B PATA to USB enclosure) was not working. I tested various SASTA disks, even a 10TB disk, and USB Sticks, all detecting the wr= ong number of sectors instead. Reverting the change leaded to the correct detec= tion of the number of sectors and therefore I was able to boot again. I tested a= lso revision base r342785 of the file /head/stand/i386/libi386/biosdisk.c: The detection of the number of sectors is implemented the right way again and h= as improved of course. I propose the following patch to fix the regression for FreeBSD 12 Index: stand/i386/libi386/biosdisk.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- stand/i386/libi386/biosdisk.c (revision 343578) +++ stand/i386/libi386/biosdisk.c (working copy) @@ -270,8 +270,8 @@ total =3D (uint64_t)params.cylinders * params.heads * params.sectors_per_track; - if (total > 0 && bd->bd_sectors > total) - bd->bd_sectors =3D total; + if (bd->bd_sectors < total) + bd->bd_sectors =3D total; ret =3D 1; } --=20 You are receiving this mail because: You are the assignee for the bug.=