From owner-svn-ports-all@FreeBSD.ORG  Sun Jul 13 16:47:08 2014
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id A16057F3;
 Sun, 13 Jul 2014 16:47:08 +0000 (UTC)
Received: from apnoea.adamw.org (apnoea.adamw.org [204.109.59.150])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 7B28825BB;
 Sun, 13 Jul 2014 16:47:08 +0000 (UTC)
Received: from [192.168.192.25] (dhcp-108-170-169-12.cable.user.start.ca
 [108.170.169.12])
 (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by apnoea.adamw.org (Postfix) with ESMTPSA id 40FCC12B0DC;
 Sun, 13 Jul 2014 12:40:41 -0400 (EDT)
Content-Type: text/plain; charset=windows-1252
Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\))
Subject: Re: svn commit: r361631 - head/multimedia/vlc
From: Adam Weinberger <adamw@adamw.org>
In-Reply-To: <201407121803.s6CI3OOe033915@svn.freebsd.org>
Date: Sun, 13 Jul 2014 12:40:38 -0400
Content-Transfer-Encoding: quoted-printable
Message-Id: <40140582-EA6A-4ACB-9A28-93A6647B46B7@adamw.org>
References: <201407121803.s6CI3OOe033915@svn.freebsd.org>
To: Juergen Lock <nox@FreeBSD.org>
X-Mailer: Apple Mail (2.1878.6)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 13 Jul 2014 16:47:08 -0000

On 12 Jul, 2014, at 14:03, Juergen Lock <nox@FreeBSD.org> wrote:

> Modified: head/multimedia/vlc/Makefile
> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
> --- head/multimedia/vlc/Makefile	Sat Jul 12 17:58:06 2014	=
(r361630)
> +++ head/multimedia/vlc/Makefile	Sat Jul 12 18:03:24 2014	=
(r361631)
> @@ -198,6 +198,7 @@ MTP_CONFIGURE_ENABLE=3D	mtp
>=20
> MUSEPACK_LIB_DEPENDS=3D	libmpcdec.so:${PORTSDIR}/audio/musepack
> MUSEPACK_CONFIGURE_ENABLE=3D	mpc
> +MUSEPACK_CONFIGURE_ENV=3D		LIBS_mpc=3D"-L${LOCALBASE}/lib =
-lmpcdec=94

You want MUSEPACK_CONFIGURE_ON here. ${opt}_CONFIGURE_ENV doesn=92t =
exist.

bapt can tell you how many times I=92ve made that mistake...

# Adam


--=20
Adam Weinberger
adamw@adamw.org
http://www.adamw.org