From owner-freebsd-virtualization@FreeBSD.ORG  Mon Oct 27 18:30:53 2014
Return-Path: <owner-freebsd-virtualization@FreeBSD.ORG>
Delivered-To: freebsd-virtualization@freebsd.org
Received: from hammer.pct.niksun.com (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by hub.freebsd.org (Postfix) with ESMTP id 583251FD;
 Mon, 27 Oct 2014 18:30:53 +0000 (UTC)
Message-ID: <544E8F5C.6070009@FreeBSD.org>
Date: Mon, 27 Oct 2014 14:30:52 -0400
From: Jung-uk Kim <jkim@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:31.0) Gecko/20100101 Thunderbird/31.2.0
MIME-Version: 1.0
To: Conrad Meyer <cse.cem@gmail.com>, John Baldwin <jhb@freebsd.org>
Subject: Re: Rework hypervisor detection
References: <3183374.mZUFeIh4pp@ralph.baldwin.cx>
 <CAG6CVpV8i6h6k=rJfNSG3Y2voAjLaQH97FTdO+hGGUO7T7rN7A@mail.gmail.com>
 <544E7DFD.2040408@FreeBSD.org>
In-Reply-To: <544E7DFD.2040408@FreeBSD.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: delphij@freebsd.org,
 "freebsd-virtualization@freebsd.org" <freebsd-virtualization@freebsd.org>
X-BeenThere: freebsd-virtualization@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "Discussion of various virtualization techniques FreeBSD supports."
 <freebsd-virtualization.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-virtualization>, 
 <mailto:freebsd-virtualization-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-virtualization/>
List-Post: <mailto:freebsd-virtualization@freebsd.org>
List-Help: <mailto:freebsd-virtualization-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-virtualization>, 
 <mailto:freebsd-virtualization-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 27 Oct 2014 18:30:53 -0000

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2014-10-27 13:16:45 -0400, Jung-uk Kim wrote:
2014년 10월 27일 13:16에 Jung-uk Kim 이(가) 쓴 글:> On 2014-10-27
12:47:13 -0400, Conrad Meyer wrote:
>> Hi John,
> 
>> I don't have access to phabricator so I'll try and review in 
>> email.
> 
>>> +#ifdef XEN +int vm_guest = VM_GUEST_XEN; +#else +int vm_guest
>>> = VM_GUEST_NO; /* Running as virtual machine guest? */ +#endif
> 
>> The whitespace between 'int' and 'vm_guest' in the second line 
>> seems wrong (extra space?).
> 
>> For vmware_hvcall() in x86/include/vmware.h, are you sure the 
>> inline assembly is correct? Have you tried the detection on a 
>> VMware VM? VMware's documentation specifies the arguments in a 
>> different order[0], and at Isilon when we tried the port-based 
>> detection in a slightly older revision of CURRENT, it didn't
>> work (IIRC).
> 
>> Everything else looks good to me, thanks.
> 
>> [0]: 
>> http://kb.vmware.com/selfservice/microsites/search.do?language=en_US&cmd=displayKC&externalId=1009458
>
>> 
> I wrote the code and it worked for me at the time.  I'll try again
> soon.

I just tested the function and it still works well.

Jung-uk Kim
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBAgAGBQJUTo9cAAoJEHyflib82/FGLOAIAJYFN2KVlaLgmVTtOX5uU/yf
gjazSIRLzQopS/yMUDvZ0hSJovoqFtHpUHTWwIMhqbpKD0u2OehTVWrt+frYrrG1
R0DHlWXIeBkfgdp3fD/6jW5Bbq1yNidn6arquSbbhxLROOTkuE0jiHUHYhgkD89a
ZluWuHfuNCPrAYEfLKAOs739ocQO+xZe+jeS2lae74bSgE06kRnQgx72Cv7ZZU35
l3C152sJKuDR+P9DOxi/mLdWcNXO76YFXkmt2JvIey2FUsw3fCIYXbN0FOz/dWD6
q8DaSCWjxYHs1TLPCueBrOgOyIzDQ5Ky4l1V/8aBROigtgmVsxv0U/rKZO5pSSs=
=dG0n
-----END PGP SIGNATURE-----