From owner-svn-src-head@freebsd.org  Sun Oct 21 02:08:41 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0E11AFFFD91;
 Sun, 21 Oct 2018 02:08:41 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id B05E7755EF;
 Sun, 21 Oct 2018 02:08:40 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1354)
 id A64EDFB93; Sun, 21 Oct 2018 02:08:40 +0000 (UTC)
From: Jan Beich <jbeich@FreeBSD.org>
To: Glen Barber <gjb@FreeBSD.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r339436 - in head: . contrib/gcc
 gnu/usr.bin/cc/cc_tools lib/clang release sys/conf sys/sys
References: <201810190037.w9J0blks031617@repo.freebsd.org>
Date: Sun, 21 Oct 2018 04:08:36 +0200
In-Reply-To: <201810190037.w9J0blks031617@repo.freebsd.org> (Glen Barber's
 message of "Fri, 19 Oct 2018 00:37:47 +0000 (UTC)")
Message-ID: <o9bo-oxuj-wny@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 21 Oct 2018 02:08:41 -0000

Glen Barber <gjb@FreeBSD.org> writes:

> Modified: head/lib/clang/llvm.build.mk
> ==============================================================================
> --- head/lib/clang/llvm.build.mk	Fri Oct 19 00:24:23 2018	(r339435)
> +++ head/lib/clang/llvm.build.mk	Fri Oct 19 00:37:47 2018	(r339436)
> @@ -17,7 +17,7 @@ CFLAGS+=	-I${LLVM_SRCS}/include
>  CFLAGS+=	-DLLVM_BUILD_GLOBAL_ISEL
>  CFLAGS+=	-D__STDC_LIMIT_MACROS
>  CFLAGS+=	-D__STDC_CONSTANT_MACROS
> -#CFLAGS+=	-DNDEBUG
> +CFLAGS+=	-DNDEBUG

Would Clang still hit asserts instead of crashing with cryptic messages?