Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 4 Dec 1998 10:46:50 -0500 (EST)
From:      Luoqi Chen <luoqi@watermarkgroup.com>
To:        freebsd-current@FreeBSD.ORG, kuehn@rz.tu-clausthal.de
Subject:   Re: panic: ffs_blkfree: bad size
Message-ID:  <199812041546.KAA24938@lor.watermarkgroup.com>

next in thread | raw e-mail | index | archive | help
> I had such a panic today too during cvsup activity. Two filesystems
> don't have softupdates. All others do. The activity was on one
> of those softupdates filesystems.
> 
> dev=0x20404, bno = 13, bsize = 8192, size = 8192, fs = /var
> panic: ffs_blkfree: bad size
> 
bno is a fs block number and for /var it almost surely can't be 13. This
still points to a missing VOP_BMAP() somewhere.

While I'm writing this message, I took another look at Kirk's patch. It seems
to me that he forgot to call VOP_BMAP() for the last buf in the reallocation
list. Try this patch, and see if you still get the panic,

Index: vfs_cluster.c
===================================================================
RCS file: /home/ncvs/src/sys/kern/vfs_cluster.c,v
retrieving revision 1.74
diff -u -r1.74 vfs_cluster.c
--- vfs_cluster.c	1998/11/17 00:31:12	1.74
+++ vfs_cluster.c	1998/12/04 15:33:09
@@ -839,7 +839,10 @@
 			VOP_BMAP(bp->b_vp, bp->b_lblkno, NULL, &bp->b_blkno,
 				NULL, NULL);
 	}
-	buflist->bs_children[i] = last_bp;
+	buflist->bs_children[i] = bp = last_bp;
+	if (bp->b_blkno == bp->b_lblkno)
+		VOP_BMAP(bp->b_vp, bp->b_lblkno, NULL, &bp->b_blkno,
+			NULL, NULL);
 	buflist->bs_nchildren = i + 1;
 	return (buflist);
 }

> The /var filesystem does not have soft updates enabled.
> I got a dump, but not from a debugging kernel.
> 
A dump from a non-debugging kernel is as good as a debugging one. Could you
post a stack backtrace?

> [ current as of Dec 2 ]
> 
> Bye,
>    Ronald
> -- 
> * The Theorem Theorem: If If, Then Then.
> 

-lq

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199812041546.KAA24938>