From owner-svn-ports-all@FreeBSD.ORG  Sun Jul 13 16:49:37 2014
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id C983B9BF;
 Sun, 13 Jul 2014 16:49:37 +0000 (UTC)
Received: from mail-wi0-x229.google.com (mail-wi0-x229.google.com
 [IPv6:2a00:1450:400c:c05::229])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id E7B7B25CD;
 Sun, 13 Jul 2014 16:49:36 +0000 (UTC)
Received: by mail-wi0-f169.google.com with SMTP id n3so1415131wiv.4
 for <multiple recipients>; Sun, 13 Jul 2014 09:49:35 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=sender:date:from:to:cc:subject:message-id:references:mime-version
 :content-type:content-disposition:in-reply-to:user-agent;
 bh=HvbqSNdRWHhnUaQiqtlwKXY9tq0iliKYrKkB32oPgrk=;
 b=JOz7nFWEjCta973NZGnaa4OtVp7E19GtpayU3QQgwKW+xrkZ6tM3bMPt9hIk6DzJUD
 1cONuuT8ddeBMNXVPGfTpzTN1LzwHECHHw4L9FDQMsiJyX9x0DQOoy4HsSQhlxa2JfGo
 PoDSyzoTpMGZBM56F1IEsOqd3ivLoTz9cWofn2Hsp6Ss8xRsmltiaHKAvY8CCfgJy3ed
 sOdCEiCn0VNba4zVD5zT5tadYdDcYsO2AJDaTw6++YKuE9PKDkIvacjbqhd8KtNRQbEC
 CsY+cDRh7RJBFOs3Ss/tehiuhE5MR0LSNVBxLOiCLY/1B3A+6/5ghxRd2TYKvly7ZML2
 dXnA==
X-Received: by 10.180.198.173 with SMTP id jd13mr19329568wic.9.1405270175306; 
 Sun, 13 Jul 2014 09:49:35 -0700 (PDT)
Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1])
 by mx.google.com with ESMTPSA id ft17sm19609292wjc.14.2014.07.13.09.49.30
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Sun, 13 Jul 2014 09:49:31 -0700 (PDT)
Sender: Baptiste Daroussin <baptiste.daroussin@gmail.com>
Date: Sun, 13 Jul 2014 18:49:29 +0200
From: Baptiste Daroussin <bapt@FreeBSD.org>
To: Adam Weinberger <adamw@adamw.org>
Subject: Re: svn commit: r361631 - head/multimedia/vlc
Message-ID: <20140713164929.GO93051@ivaldir.etoilebsd.net>
References: <201407121803.s6CI3OOe033915@svn.freebsd.org>
 <40140582-EA6A-4ACB-9A28-93A6647B46B7@adamw.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature"; boundary="vEfizQhTV1P/vojJ"
Content-Disposition: inline
In-Reply-To: <40140582-EA6A-4ACB-9A28-93A6647B46B7@adamw.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: svn-ports-head@freebsd.org, Juergen Lock <nox@FreeBSD.org>,
 svn-ports-all@freebsd.org, ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 13 Jul 2014 16:49:37 -0000


--vEfizQhTV1P/vojJ
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Jul 13, 2014 at 12:40:38PM -0400, Adam Weinberger wrote:
> On 12 Jul, 2014, at 14:03, Juergen Lock <nox@FreeBSD.org> wrote:
>=20
> > Modified: head/multimedia/vlc/Makefile
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
> > --- head/multimedia/vlc/Makefile	Sat Jul 12 17:58:06 2014	(r361630)
> > +++ head/multimedia/vlc/Makefile	Sat Jul 12 18:03:24 2014	(r361631)
> > @@ -198,6 +198,7 @@ MTP_CONFIGURE_ENABLE=3D	mtp
> >=20
> > MUSEPACK_LIB_DEPENDS=3D	libmpcdec.so:${PORTSDIR}/audio/musepack
> > MUSEPACK_CONFIGURE_ENABLE=3D	mpc
> > +MUSEPACK_CONFIGURE_ENV=3D		LIBS_mpc=3D"-L${LOCALBASE}/lib -lmpcdec=E2=
=80=9D
>=20
> You want MUSEPACK_CONFIGURE_ON here. ${opt}_CONFIGURE_ENV doesn=E2=80=99t=
 exist.
>=20
> bapt can tell you how many times I=E2=80=99ve made that mistake...

Well ${opt}_CONFIGURE_ENV does exists :) your mistake was another one I don=
't
remember :)

regards,
Bapt

--vEfizQhTV1P/vojJ
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEARECAAYFAlPCuJkACgkQ8kTtMUmk6Ex/jQCePoGhnRR6307yWfjeOUohG59r
c8AAnis2Y2PQyeL2y7YvzsWPRTFMBTDu
=3v62
-----END PGP SIGNATURE-----

--vEfizQhTV1P/vojJ--