From owner-svn-src-all@FreeBSD.ORG Wed Apr 6 21:29:38 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 49802106566B; Wed, 6 Apr 2011 21:29:38 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 1AFDE8FC15; Wed, 6 Apr 2011 21:29:38 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id C634946B97; Wed, 6 Apr 2011 17:29:37 -0400 (EDT) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 46F6B8A01B; Wed, 6 Apr 2011 17:29:37 -0400 (EDT) From: John Baldwin To: Kostik Belousov Date: Wed, 6 Apr 2011 16:03:43 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110325; KDE/4.5.5; amd64; ; ) References: <201104061627.p36GR4Vx097282@svn.freebsd.org> <28CBF3B2-105E-4B0F-A1B1-4FA772BAB06A@freebsd.org> <20110406192728.GH78089@deviant.kiev.zoral.com.ua> In-Reply-To: <20110406192728.GH78089@deviant.kiev.zoral.com.ua> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201104061603.43636.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (bigwig.baldwin.cx); Wed, 06 Apr 2011 17:29:37 -0400 (EDT) Cc: Garrett Cooper , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Edward Tomasz Napiera?a Subject: Re: svn commit: r220387 - head/sys/vm X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Apr 2011 21:29:38 -0000 On Wednesday, April 06, 2011 3:27:28 pm Kostik Belousov wrote: > On Wed, Apr 06, 2011 at 07:04:47PM +0200, Edward Tomasz Napiera?a wrote: > > Wiadomo?? napisana przez Garrett Cooper w dniu 2011-04-06, o godz. 18:57: > > > On Wed, Apr 6, 2011 at 9:27 AM, Edward Tomasz Napierala > > > wrote: > > >> Author: trasz > > >> Date: Wed Apr 6 16:27:04 2011 > > >> New Revision: 220387 > > >> URL: http://svn.freebsd.org/changeset/base/220387 > > >> > > >> Log: > > >> In vm_daemon(), do not skip processes stopped with SIGSTOP. > > > > > > Did you run this by anyone else before you committed the change? > > > > The whole racct patchset was reviewed by kib@, and I seem to remember > > that he said this might cause problems. However, I didn't encounter > > any problems with this, neither did any person testing the patchset. > > > > So, what's wrong with this? > I remember that I disliked the whole approach of handling RSS limits, > and still hold the same opinion. > I said something about honoring the limit at the time of page allocation > or page-in, and not `offline' as it is committed, by periodic scans > by daemon. Yes, to be truly useful the limit has to prevent excessive page allocation at the time the allocation is performed (by blocking until another page is swapped out or failing, etc.). -- John Baldwin