From owner-svn-ports-all@FreeBSD.ORG  Sun Jul 13 16:53:31 2014
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 0EAD8CAC;
 Sun, 13 Jul 2014 16:53:31 +0000 (UTC)
Received: from apnoea.adamw.org (apnoea.adamw.org [204.109.59.150])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 43CAD2659;
 Sun, 13 Jul 2014 16:53:30 +0000 (UTC)
Received: from [192.168.192.25] (dhcp-108-170-169-12.cable.user.start.ca
 [108.170.169.12])
 (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by apnoea.adamw.org (Postfix) with ESMTPSA id 1E70B12B02A;
 Sun, 13 Jul 2014 12:53:27 -0400 (EDT)
Content-Type: text/plain; charset=windows-1252
Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\))
Subject: Re: svn commit: r361631 - head/multimedia/vlc
From: Adam Weinberger <adamw@adamw.org>
In-Reply-To: <20140713164929.GO93051@ivaldir.etoilebsd.net>
Date: Sun, 13 Jul 2014 12:53:25 -0400
Content-Transfer-Encoding: quoted-printable
Message-Id: <E126F391-6BC7-400B-9886-C739F2C9DE9B@adamw.org>
References: <201407121803.s6CI3OOe033915@svn.freebsd.org>
 <40140582-EA6A-4ACB-9A28-93A6647B46B7@adamw.org>
 <20140713164929.GO93051@ivaldir.etoilebsd.net>
To: Baptiste Daroussin <bapt@FreeBSD.org>
X-Mailer: Apple Mail (2.1878.6)
Cc: svn-ports-head@freebsd.org, Juergen Lock <nox@FreeBSD.org>,
 svn-ports-all@freebsd.org, ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 13 Jul 2014 16:53:31 -0000

On 13 Jul, 2014, at 12:49, Baptiste Daroussin <bapt@FreeBSD.org> wrote:

> On Sun, Jul 13, 2014 at 12:40:38PM -0400, Adam Weinberger wrote:
>> On 12 Jul, 2014, at 14:03, Juergen Lock <nox@FreeBSD.org> wrote:
>>=20
>>> Modified: head/multimedia/vlc/Makefile
>>> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
>>> --- head/multimedia/vlc/Makefile	Sat Jul 12 17:58:06 2014	=
(r361630)
>>> +++ head/multimedia/vlc/Makefile	Sat Jul 12 18:03:24 2014	=
(r361631)
>>> @@ -198,6 +198,7 @@ MTP_CONFIGURE_ENABLE=3D	mtp
>>>=20
>>> MUSEPACK_LIB_DEPENDS=3D	libmpcdec.so:${PORTSDIR}/audio/musepack
>>> MUSEPACK_CONFIGURE_ENABLE=3D	mpc
>>> +MUSEPACK_CONFIGURE_ENV=3D		LIBS_mpc=3D"-L${LOCALBASE}/lib =
-lmpcdec=94
>>=20
>> You want MUSEPACK_CONFIGURE_ON here. ${opt}_CONFIGURE_ENV doesn=92t =
exist.
>>=20
>> bapt can tell you how many times I=92ve made that mistake...
>=20
> Well ${opt}_CONFIGURE_ENV does exists :) your mistake was another one =
I don't
> remember :)
>=20
> regards,
> Bapt

Oh, crap! That=92s right... it was _CONFIGURE_ARGS that I keep trying =
for. I give _CONFIGURE_* a 10-foot berth now.

# Adam


--=20
Adam Weinberger
adamw@adamw.org
http://www.adamw.org