Date: Fri, 20 Jan 2012 15:35:35 -0800 From: Xin Li <delphij@delphij.net> To: Eitan Adler <lists@eitanadler.com> Cc: Kostik Belousov <kostikbel@gmail.com>, jilles@freebsd.org, d@delphij.net, Colin Percival <cperciva@freebsd.org>, FreeBSD Hackers <freebsd-hackers@freebsd.org> Subject: Re: dup3 syscall - atomic set O_CLOEXEC with dup2 Message-ID: <4F19FA47.7060908@delphij.net> In-Reply-To: <CAF6rxg=Xbh--nL3pebj=ra%2B09K%2BWJYen2JPVDWwR14%2BifG-_iQ@mail.gmail.com> References: <CAF6rxg=EjkwFbXQt3i2Nnz6_dcZtdek-2YdqyZnAdVPxVaWR_Q@mail.gmail.com> <20120112100840.GV31224@deviant.kiev.zoral.com.ua> <CAF6rxgne7M9xBb-mM1xsjPy3r-O%2BO%2BMzuYrsweG849V83MX3mA@mail.gmail.com> <CAF6rxgn5uddFb4LOGb0E_OOpVMiFavOVHwnrKF7cFHb6tfrPjw@mail.gmail.com> <CAF6rxg=Xbh--nL3pebj=ra%2B09K%2BWJYen2JPVDWwR14%2BifG-_iQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, Eitan, On 01/20/12 15:25, Eitan Adler wrote: > I figure this isn't wanted? Since this is modeled after Linux's dup3() system call, would you please also add a compat entry for it? By the way: > On Thu, Jan 12, 2012 at 10:07 PM, Eitan Adler > <lists@eitanadler.com> wrote: >> Okay - here is version 2 (compile and run tested) Index: >> sys/kern/syscalls.master >> =================================================================== >> >> - --- sys/kern/syscalls.master (revision 229830) >> +++ sys/kern/syscalls.master (working copy) @@ -951,5 +951,6 >> @@ off_t offset, off_t len); } 531 AUE_NULL STD { >> int posix_fadvise(int fd, off_t offset, \ off_t len, int advice); >> } +532 AUE_NULL STD { int dup3(u_int from, u_int >> to, int flags); } I think we want audit here? >> ; Please copy any additions and changes to the following >> compatability tables: ; sys/compat/freebsd32/syscalls.master >> Index: sys/compat/freebsd32/syscalls.master >> =================================================================== >> >> - --- sys/compat/freebsd32/syscalls.master (revision 229830) >> +++ sys/compat/freebsd32/syscalls.master (working copy) @@ >> -997,3 +997,4 @@ uint32_t offset1, uint32_t offset2,\ uint32_t >> len1, uint32_t len2, \ int advice); } +532 AUE_NULL STD >> { int dup3(u_int from, u_int to, int flags); } Ditto... Cheers, - -- Xin LI <delphij@delphij.net> https://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (FreeBSD) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk8Z+kYACgkQOfuToMruuMBe/ACfQ9aR5OfPZTS3q/AVNheUDliQ nIYAnjp/5qblxlOLDAvB6AferlpFQjOa =lTV+ -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4F19FA47.7060908>