From owner-svn-src-head@freebsd.org Mon Sep 26 00:20:36 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9A1F1BEA6BE; Mon, 26 Sep 2016 00:20:36 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-it0-f41.google.com (mail-it0-f41.google.com [209.85.214.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6C3B51B20; Mon, 26 Sep 2016 00:20:36 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-it0-f41.google.com with SMTP id n143so61514134ita.1; Sun, 25 Sep 2016 17:20:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc:content-transfer-encoding; bh=rUJXHxonjRWZqFae3DM5I3vpwo7P7nG9PY3cSvxu6mU=; b=NdqhRqZF6y2DwH48QRdc23ehaYnxh63QeNic4VoSWkWlUrFkOHSZCiuz824pkhCM+C BhYTPYpge/2Rq92ZU4APzffMcaC3RDJV+K4RitC9MHR21nAWPO7U+dOtomQR+hRiRVyP aMIm4y0LSdBfN9y/mPKHQMRKqudbMPe6T5NQa/diweYc0bh/paWN6CrezVAjOk3XFxCG xynGMaUVBNcwhaK0NylGfJH+utz6ZdpYy5cIjsPBQ/Dok5z2rlpFXwG0Ec1w5jzSKj/Y T3cWKFgigWpYErX1+tFDLAeWW2/zpY5LnMoemFKEF8mgFljqdmYMWIT38HxKsHUJePGL A0bw== X-Gm-Message-State: AA6/9RkEJ3fnpoe9YL0FIE97t+dOrOLeJWHadw4FwEDEE5Ds5OLamYxaaqJ0xZK8KTRDaQ== X-Received: by 10.36.184.65 with SMTP id m62mr15162503ite.55.1474849229105; Sun, 25 Sep 2016 17:20:29 -0700 (PDT) Received: from mail-io0-f170.google.com (mail-io0-f170.google.com. [209.85.223.170]) by smtp.gmail.com with ESMTPSA id k128sm7299227ioe.20.2016.09.25.17.20.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 25 Sep 2016 17:20:28 -0700 (PDT) Received: by mail-io0-f170.google.com with SMTP id m79so167532012ioo.3; Sun, 25 Sep 2016 17:20:28 -0700 (PDT) X-Received: by 10.107.58.87 with SMTP id h84mr20585767ioa.122.1474849228680; Sun, 25 Sep 2016 17:20:28 -0700 (PDT) MIME-Version: 1.0 Reply-To: cem@freebsd.org Received: by 10.36.220.129 with HTTP; Sun, 25 Sep 2016 17:20:28 -0700 (PDT) In-Reply-To: References: <201609252257.u8PMvxUx047428@repo.freebsd.org> From: Conrad Meyer Date: Sun, 25 Sep 2016 17:20:28 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r306325 - head/usr.bin/mkimg To: Marcel Moolenaar Cc: svn-src-all@freebsd.org, svn-src-head@freebsd.org, src-committers Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Sep 2016 00:20:36 -0000 On Sun, Sep 25, 2016 at 5:09 PM, Marcel Moolenaar wrote= : > On September 25, 2016 at 4:52:17 PM, Conrad Meyer (cem@freebsd.org) wrote= : > > > What's the motivation for this? This seems worse. > > Portability. We need mkimg to compile on other OSes besides FreeBSD. In > particular, macOS and Linux. It=E2=80=99s ok that constructors are not 1= 00% > portable=E2=80=A6 That makes sense, thanks. It would be good to include that motivation in the commit message, then I don't ask stupid questions like this. :-) Best, Conrad