From owner-cvs-all@FreeBSD.ORG Wed Jun 9 03:51:53 2010 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 482691065673; Wed, 9 Jun 2010 03:51:53 +0000 (UTC) (envelope-from glewis@eyesbeyond.com) Received: from misty.eyesbeyond.com (gerbercreations.com [71.39.140.16]) by mx1.freebsd.org (Postfix) with ESMTP id EA32A8FC14; Wed, 9 Jun 2010 03:51:52 +0000 (UTC) Received: from misty.eyesbeyond.com (localhost.eyesbeyond.com [127.0.0.1]) by misty.eyesbeyond.com (8.14.4/8.14.4) with ESMTP id o593ppJ6095274; Tue, 8 Jun 2010 20:51:51 -0700 (PDT) (envelope-from glewis@eyesbeyond.com) Received: (from glewis@localhost) by misty.eyesbeyond.com (8.14.4/8.14.4/Submit) id o593poVS095273; Tue, 8 Jun 2010 20:51:50 -0700 (PDT) (envelope-from glewis@eyesbeyond.com) X-Authentication-Warning: misty.eyesbeyond.com: glewis set sender to glewis@eyesbeyond.com using -f Date: Tue, 8 Jun 2010 20:51:49 -0700 From: Greg Lewis To: Ion-Mihai Tetcu Message-ID: <20100609035149.GA94751@misty.eyesbeyond.com> References: <201006082017.o58KHb1o039986@repoman.freebsd.org> <4C0EB5E8.5040009@p6m7g8.com> <20100609004757.7a61d6f6@it.buh.tecnik93.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100609004757.7a61d6f6@it.buh.tecnik93.com> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: Rob Farmer , cvs-all@FreeBSD.org, ports-committers@FreeBSD.org, "Philip M. Gollucci" , cvs-ports@FreeBSD.org, glewis@FreeBSD.org Subject: Re: cvs commit: ports/java/jdk16 Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2010 03:51:53 -0000 On Wed, Jun 09, 2010 at 12:47:57AM +0300, Ion-Mihai Tetcu wrote: > On Tue, 8 Jun 2010 17:28:08 -0400 > "Philip M. Gollucci" wrote: > > On 6/8/2010 4:34 PM, Rob Farmer wrote: > > > On Tue, Jun 8, 2010 at 1:17 PM, Ion-Mihai Tetcu > > > wrote: > > >> itetcu 2010-06-08 20:17:37 UTC > > >> > > >> FreeBSD ports repository > > >> > > >> Modified files: > > >> java/jdk16 Makefile > > >> Log: > > >> Mark BROKEN, I'm tired to see QAT loosing time trying to build it. > > > > > > Could you move this inside an .if defined(PACKAGE_BUILDING) or > > > something? It seems a little extreme (a lot of stuff has a jdk > > > dependency) > > I know, believe me: > > ./QAT_getFailledDepends.sh -d java/jdk16 > +--------------------------------------------+ > | No. of failed ports becasue of java/jdk16: | > +--------------------------------------------+ > | 145 | > +--------------------------------------------+ > > > and I just built this yesterday on amd64 current with no issues. > > > > > Yeah I've built it too and recently (as much as I despise java) > > http://people.freebsd.org/~pgollucci/FreeBSD/logs/9-CURRENT-amd64-rubygems18/jdk-1.6.0.3p4_15.log > > > > nothing against glewis, he's doing great work. > > It's been failing each time on QAT since 15.02, and for others since > January. I don't see what it has to do with package building. > > I guess it would nor err like this after: > r200039/_FreeBSD_version 900003 for HEAD and r203299/800502 > (QAT's base OS is a 8.0-RELEASE-p2) > > However it's failing for me on an other 8-STABLE tinderbox also, which > has a much newer base OS kernel, but in a different way. > > I will invetigate more tomorrow, time permitting. Please revert your commit. Its building fine for myself and many other users. I cannot reproduce the QAT failure and there are no PRs about it. QAT complains thusly: ../../../../src/solaris/hpi/native_threads/src/interrupt_md.c:115: error: static declaration of 'sigignore' follows non-static declaration /usr/include/signal.h:103: error: previous declaration of 'sigignore' was here The build uses the following logic to detect the presence of sigignore: ifeq ($(OS_VENDOR),FreeBSD) OS_RELDATE := $(shell sysctl kern.osreldate | cut -d' ' -f2) HAS_SIGIGNORE := $(shell if [ $(OS_RELDATE) -ge 800502 -a $(OS_RELDATE) -lt 900000 -o $(OS_RELDATE) -ge 900003 ]; then echo "1"; fi) ifeq ($(HAS_SIGIGNORE),1) override HAVE_SIGIGNORE = true endif endif I suspect that works for 99.9% of users but may fail for jailed applications like QAT where syctl outputs a kern.osreldate that doesn't match the userland headers. I'm open to suggestions on different logic, but I don't feel the narrow failure mode justifies your change. If you don't want QAT to build the port then modify QAT to be able to exclude ports rather than hurting the vast majority of users for whom this port does build. FWIW the port builds without problem on my 8.0-RELEASE-p2 amd64 box. -- Greg Lewis Email : glewis@eyesbeyond.com Eyes Beyond Web : http://www.eyesbeyond.com Information Technology FreeBSD : glewis@FreeBSD.org