From owner-svn-src-all@freebsd.org Tue Mar 27 09:52:10 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6C267F67241 for ; Tue, 27 Mar 2018 09:52:10 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-yw0-x236.google.com (mail-yw0-x236.google.com [IPv6:2607:f8b0:4002:c05::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 07F567A520 for ; Tue, 27 Mar 2018 09:52:09 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: by mail-yw0-x236.google.com with SMTP id y23so7051573ywy.4 for ; Tue, 27 Mar 2018 02:52:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=lCM5xOkcWquCo97eK4TXjJkXEgQg3nCmDxbFriu46WI=; b=EDRCUUsMWMKYCuwxBnnF41JExf/ddpbjQO2SAGIGds+U/2t8fLZDI/YitmmNnj/CNh 7JCUeOpUgGDD8UjjC0x+mnn09gt0sP2iZ2CH+gOkhk3NkFV7yqSeyMZIybiA5HOTzh7s dZH06F69pOjlOLQovGTQ2LlkO2qhvo9IlUpbo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=lCM5xOkcWquCo97eK4TXjJkXEgQg3nCmDxbFriu46WI=; b=CB7Uq8CC8y+sQTvUIZfhGjsMWWXgj+v9Cd/eR7GtfojqTfN8A+9nSpis8vmpr0CATh lvNgvjiuRiG5I1rE572d8Bnqr7v+oJ/A9hqodTcPwglgrLObmnD8bv0KU/ENJ9vqFeyL QTlrcs0e6TYE3tduuxUODxvZBCL94g1HZcOb5mORBc9nZ2txh2A2sZfdEV2FUjU/lUGK 7K3mGLGQkOdydH+/Gy/ljWyPfvvHgFNPEJftmpMZdbh8GkfHUz7SmXRmHrsiM40r+RT3 5cJvqL4I43Lvf4ldQrsFSiAyhdHUfTTpsUV7qOidCctKpzbv1EO3N38tjeX1lzmKBjm5 fRyA== X-Gm-Message-State: AElRT7EEUhqhrXEVT6IgrWyUMTXV/JzrSrlyOxxPE/UTb8lsDXnl5xWi Dnl15HQDQO6cEOoSz/LspTJZXA0GDy8VZqC53+pnqA== X-Google-Smtp-Source: AG47ELuqdpxoYq/6Ug8GWIZm6uW5SdxZIIAk108ep3sv15pz8uAp54BrSAttjP9UB4AmgtyBY7blUteVo4QM/+rrjnQ= X-Received: by 10.129.114.6 with SMTP id n6mr21470525ywc.113.1522144329281; Tue, 27 Mar 2018 02:52:09 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a5b:990:0:0:0:0:0 with HTTP; Tue, 27 Mar 2018 02:51:38 -0700 (PDT) In-Reply-To: References: <201803270337.w2R3b4iv035285@repo.freebsd.org> From: Eitan Adler Date: Tue, 27 Mar 2018 02:51:38 -0700 Message-ID: Subject: Re: svn commit: r331606 - in head/sys: amd64/include i386/include x86/x86 x86/xen To: Hans Petter Selasky Cc: Jeff Roberson , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Mar 2018 09:52:10 -0000 On 27 March 2018 at 01:45, Hans Petter Selasky wrote: > On 03/27/18 05:37, Jeff Roberson wrote: >> >> do { >> - current_cpu++; >> - if (current_cpu > mp_maxid) >> - current_cpu = 0; >> - } while (!CPU_ISSET(current_cpu, &intr_cpus)); >> + current_cpu[domain]++; >> + if (current_cpu[domain] > mp_maxid) >> + current_cpu[domain] = 0; >> + } while (!CPU_ISSET(current_cpu[domain], &intr_cpus) || >> + !CPU_ISSET(current_cpu[domain], &cpuset_domain[domain])); > > > Can it happen that cpuset_domain[domain] is all zero? Won't this loop hang > then? I can replicate the hang. Let me know what other debugging information you might need. -- Eitan Adler