From owner-svn-ports-all@FreeBSD.ORG  Sun Jul 13 18:14:31 2014
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 4940EA32;
 Sun, 13 Jul 2014 18:14:31 +0000 (UTC)
Received: from mailrelay007.isp.belgacom.be (mailrelay007.isp.belgacom.be
 [195.238.6.173])
 by mx1.freebsd.org (Postfix) with ESMTP id 3E3112CD0;
 Sun, 13 Jul 2014 18:14:29 +0000 (UTC)
X-Belgacom-Dynamic: yes
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: AmEGAP7LwlNbsKzB/2dsb2JhbABZgw7KMAGBCBd1hAQBBTIBIyMQCxgJJQ8qHgYTiEYBxxwXjxgzB4RDAQSbDZQeg0Y7
Received: from 193.172-176-91.adsl-dyn.isp.belgacom.be (HELO
 kalimero.tijl.coosemans.org) ([91.176.172.193])
 by relay.skynet.be with ESMTP; 13 Jul 2014 20:13:55 +0200
Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org
 [127.0.0.1])
 by kalimero.tijl.coosemans.org (8.14.9/8.14.9) with ESMTP id s6DIDrYj012610;
 Sun, 13 Jul 2014 20:13:54 +0200 (CEST)
 (envelope-from tijl@FreeBSD.org)
Date: Sun, 13 Jul 2014 20:13:52 +0200
From: Tijl Coosemans <tijl@FreeBSD.org>
To: Adam Weinberger <adamw@adamw.org>
Subject: Re: svn commit: r361631 - head/multimedia/vlc
Message-ID: <20140713201352.62e74754@kalimero.tijl.coosemans.org>
In-Reply-To: <E126F391-6BC7-400B-9886-C739F2C9DE9B@adamw.org>
References: <201407121803.s6CI3OOe033915@svn.freebsd.org>
 <40140582-EA6A-4ACB-9A28-93A6647B46B7@adamw.org>
 <20140713164929.GO93051@ivaldir.etoilebsd.net>
 <E126F391-6BC7-400B-9886-C739F2C9DE9B@adamw.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Cc: svn-ports-head@freebsd.org, Juergen Lock <nox@FreeBSD.org>,
 Baptiste Daroussin <bapt@FreeBSD.org>, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 13 Jul 2014 18:14:31 -0000

On Sun, 13 Jul 2014 12:53:25 -0400 Adam Weinberger wrote:
> On 13 Jul, 2014, at 12:49, Baptiste Daroussin <bapt@FreeBSD.org> wrote:
>> On Sun, Jul 13, 2014 at 12:40:38PM -0400, Adam Weinberger wrote:
>>> On 12 Jul, 2014, at 14:03, Juergen Lock <nox@FreeBSD.org> wrote:
>>> 
>>>> Modified: head/multimedia/vlc/Makefile
>>>> ==============================================================================
>>>> --- head/multimedia/vlc/Makefile	Sat Jul 12 17:58:06 2014	(r361630)
>>>> +++ head/multimedia/vlc/Makefile	Sat Jul 12 18:03:24 2014	(r361631)
>>>> @@ -198,6 +198,7 @@ MTP_CONFIGURE_ENABLE=	mtp
>>>> 
>>>> MUSEPACK_LIB_DEPENDS=	libmpcdec.so:${PORTSDIR}/audio/musepack
>>>> MUSEPACK_CONFIGURE_ENABLE=	mpc
>>>> +MUSEPACK_CONFIGURE_ENV=		LIBS_mpc="-L${LOCALBASE}/lib -lmpcdec”
>>> 
>>> You want MUSEPACK_CONFIGURE_ON here. ${opt}_CONFIGURE_ENV doesn’t exist.
>>> 
>>> bapt can tell you how many times I’ve made that mistake...
>> 
>> Well ${opt}_CONFIGURE_ENV does exists :) your mistake was another one I don't
>> remember :)
> 
> Oh, crap! That’s right... it was _CONFIGURE_ARGS that I keep trying for. I
> give _CONFIGURE_* a 10-foot berth now.

Now that we have *_OFF we could make CONFIGURE_ARGS the same
as CONFIGURE_ENV by adding support for *_CONFIGURE_ARGS and
*_CONFIGURE_ARGS_OFF (and maybe mark *_CONFIGURE_ON and
*_CONFIGURE_OFF deprecated).