From owner-svn-src-all@freebsd.org Tue May 7 05:32:06 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8B8AD159FCC0; Tue, 7 May 2019 05:32:06 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id F151D71F53; Tue, 7 May 2019 05:32:05 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x475VuuM010070; Mon, 6 May 2019 22:31:56 -0700 (PDT) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: (from freebsd@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id x475VuIY010069; Mon, 6 May 2019 22:31:56 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201905070531.x475VuIY010069@gndrsh.dnsmgr.net> Subject: Re: svn commit: r347218 - head/sys/compat/linsysfs In-Reply-To: <201905070508.x4758DW5015688@repo.freebsd.org> To: Dmitry Chagin Date: Mon, 6 May 2019 22:31:56 -0700 (PDT) CC: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: F151D71F53 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.96 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.96)[-0.957,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 May 2019 05:32:06 -0000 > Author: dchagin > Date: Tue May 7 05:08:13 2019 > New Revision: 347218 > URL: https://svnweb.freebsd.org/changeset/base/347218 > > Log: > Remove wrong copyright line. Discussed with Carlos Neira. > > Reported by: Rodney W. Grimes normally just use a committers username, aka rgrimes or rgrimes@ for these types of things. > MFC after: 2 weeks > Differential Revision: https://reviews.freebsd.org/D13656 Hang on, now you removed his copyright? I see he said that was ok, but that was not the desired intent here. It would of been fine to have the copyright read: * Copyright (c) 2006 IronPort Systems * All rights reserved. * Copyright (c) 2017 Carlos Neira cneirabustos@gmail.com As a heads up to other committers you should never insert your copyright between another copyright and the "All rights reserved." text, if you wish to assert the all rights reserved you should duplicate it like: * Copyright (c) 2006 IronPort Systems * All rights reserved. * Copyright (c) 2017 Carlos Neira cneirabustos@gmail.com * All rights reserved. preferably on the line with your copyright as in: * Copyright (c) 2017 Carlos Neira cneirabustos@gmail.com All rights reserved. But if at all possible it would be best if we could not add any more of these, and remove them when possible. For those wishing to save space the (c) is unneeded when you spell out the word "Copyright". > > Modified: > head/sys/compat/linsysfs/linsysfs.c > > Modified: head/sys/compat/linsysfs/linsysfs.c > ============================================================================== > --- head/sys/compat/linsysfs/linsysfs.c Tue May 7 01:27:23 2019 (r347217) > +++ head/sys/compat/linsysfs/linsysfs.c Tue May 7 05:08:13 2019 (r347218) > @@ -2,7 +2,6 @@ > * SPDX-License-Identifier: BSD-2-Clause-FreeBSD > * > * Copyright (c) 2006 IronPort Systems > - * Copyright (c) 2017 Carlos Neira cneirabustos@gmail.com > * All rights reserved. > * > * Redistribution and use in source and binary forms, with or without > > -- Rod Grimes rgrimes@freebsd.org