From owner-freebsd-current@FreeBSD.ORG  Thu Oct 13 20:21:31 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: freebsd-current@freebsd.org
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 9B87616A41F
	for <freebsd-current@freebsd.org>; Thu, 13 Oct 2005 20:21:31 +0000 (GMT)
	(envelope-from phk@critter.freebsd.dk)
Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222])
	by mx1.FreeBSD.org (Postfix) with ESMTP id C1C0843D48
	for <freebsd-current@freebsd.org>; Thu, 13 Oct 2005 20:21:30 +0000 (GMT)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (unknown [192.168.48.2])
	by phk.freebsd.dk (Postfix) with ESMTP id CF64BBC7A;
	Thu, 13 Oct 2005 20:21:28 +0000 (UTC)
To: Eric Anderson <anderson@centtech.com>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Thu, 13 Oct 2005 14:41:14 CDT."
	<434EB85A.9030308@centtech.com> 
Date: Thu, 13 Oct 2005 22:21:27 +0200
Message-ID: <9523.1129234887@critter.freebsd.dk>
Sender: phk@critter.freebsd.dk
Cc: FreeBSD Current <freebsd-current@freebsd.org>
Subject: Re: ufsstat - testers / feedback wanted! 
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Oct 2005 20:21:31 -0000

In message <434EB85A.9030308@centtech.com>, Eric Anderson writes:
>Poul-Henning Kamp wrote:

>> I would far to prefer to see a generic method that would work
>> on all filesystems types, rather than a ufs specific tool.
>> 
>> If you added counting code to the VOP_FOO() expansions, you should
>> be able to gather statistics for all filesystem types.
>> 
>> The collection could be controlled by a mount option if the impact
>> is too big.
>
>That's an idea I thought of as well, but wanted to start small, since I 
>really am new to C programming.  Now that I've done this part, I'll look 
>at the various vop_* pieces and see if it's something in my grasp.

I'd prefer for us to not commit a ufs-only solution, that would be
enough to hold off a filesystem independent solution.

> From what it sounds like, you'd also like to see per-mount point stats, 
>but from the vfs layer, right?   If that's true, then do you have any 
>suggestions on how to store the statistics for each mounted fs?

In struct mount ?

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.