Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 21 Jul 2000 12:35:39 +0200 (CEST)
From:      Mads Bondo Dydensborg <madsdyd@challenge.dk>
To:        "'aic7xxx@FreeBSD.ORG'" <aic7xxx@FreeBSD.ORG>
Subject:   Redundant code in aic7xxx_proc.c?
Message-ID:  <Pine.LNX.4.21.0007211230550.31696-100000@challenge.dk>

next in thread | raw e-mail | index | archive | help
Hello.

I have been confused by these lines in the function aic7xxx_proc_info in 
aic7xxx_proc.c:

---------------
  HBAptr = p->host;

  if (inout == TRUE) /* Has data been written to the file? */ 
  {
    return (aic7871_set_info(buffer, length, HBAptr));
  }

  p = (struct aic7871_host *) HBAptr->hostdata;
---------------

Isn't the last line redundant? I mean, if p should change its value based
on that assignment, wouldn't something be really wrong/weird?

BTW: this is the file as distributed in kernel 2.2.13.

Mads

-- 
Mads Bondo Dydensborg.                               madsdyd@challenge.dk
Pretty cool, the kind of power information technology puts in our hands
these days. 
    - Securityfocus on probing 36000000 hosts for known problems in 3 weeks



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe aic7xxx" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.LNX.4.21.0007211230550.31696-100000>