From owner-freebsd-hackers  Sun Dec 17 21: 2: 2 2000
From owner-freebsd-hackers@FreeBSD.ORG  Sun Dec 17 21:02:01 2000
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from rover.village.org (rover.village.org [204.144.255.66])
	by hub.freebsd.org (Postfix) with ESMTP id 5A62D37B400
	for <hackers@FreeBSD.ORG>; Sun, 17 Dec 2000 21:02:00 -0800 (PST)
Received: from harmony.village.org (harmony.village.org [10.0.0.6])
	by rover.village.org (8.11.0/8.11.0) with ESMTP id eBI51xs05493;
	Sun, 17 Dec 2000 22:01:59 -0700 (MST)
	(envelope-from imp@harmony.village.org)
Received: from harmony.village.org (localhost.village.org [127.0.0.1]) by harmony.village.org (8.9.3/8.8.3) with ESMTP id WAA87838; Sun, 17 Dec 2000 22:01:58 -0700 (MST)
Message-Id: <200012180501.WAA87838@harmony.village.org>
To: "Jacques A. Vidrine" <n@nectar.com>
Subject: Re: Why not another style thread? (was Re: cvs commit: src/lib/libc/gen getgrent.c) 
Cc: Chris Costello <chris@calldei.com>, hackers@FreeBSD.ORG
In-reply-to: Your message of "Sun, 17 Dec 2000 17:03:16 CST."
		<20001217170316.A63227@hamlet.nectar.com> 
References: <20001217170316.A63227@hamlet.nectar.com>  <200012172110.eBHLAfU46563@freefall.freebsd.org> <20001217151509.A63051@hamlet.nectar.com> <20001217151735.D54486@holly.calldei.com> <20001217153129.B63080@hamlet.nectar.com> <20001217153656.F54486@holly.calldei.com> <20001217155648.C63080@hamlet.nectar.com> <20001217160442.H54486@holly.calldei.com> 
Date: Sun, 17 Dec 2000 22:01:58 -0700
From: Warner Losh <imp@village.org>
Sender: imp@harmony.village.org
Sender: owner-freebsd-hackers@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

In message <20001217170316.A63227@hamlet.nectar.com> "Jacques A. Vidrine" writes:
: I hate to give up a line for
: 
:       if (data)
:               free(data);
: 
: but neither do I care for ``if (data) free(data);''.  I guess if I 
: were writing several statements like that in a single file, I would
: consider the macro route (e.g. xfree).

No offense, but this strikes me as a premature, sub-micro
optimization.  I doubt that you could measure any difference between
	if (foo) free(foo);
and	free(foo);

in the real world.

Warner


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message